Skip to content

Commit

Permalink
Add CI for disabling detail logging. (project-chip#8171)
Browse files Browse the repository at this point in the history
This way we won't have to worry about problems popping up if/when
someone tries to do that.

For now assuming no one really plans to disable error logging.
  • Loading branch information
bzbarsky-apple authored Jul 9, 2021
1 parent 046f46a commit b9620ec
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@ jobs:

strategy:
matrix:
type: [gcc_debug, gcc_release, clang, mbedtls, clang_experimental]
type: [gcc_debug, gcc_release, clang, mbedtls, clang_experimental, no_detail_logging]
# Disabling progress logging does not compile yet. Once it does, we can add the no_progress_logging type.
env:
BUILD_TYPE: ${{ matrix.type }}
DETAIL_LOGGING: ${{ matrix.type != 'no_detail_logging' && matrix.type != 'no_progress_logging' }}
PROGRESS_LOGGING: ${{ matrix.type != 'no_progress_logging' }}

runs-on: ubuntu-latest
if: github.actor != 'restyled-io[bot]'
Expand Down Expand Up @@ -85,7 +88,7 @@ jobs:
*) ;;
esac
scripts/build/gn_gen.sh --args="$GN_ARGS"
scripts/build/gn_gen.sh --args="$GN_ARGS chip_detail_logging=${DETAIL_LOGGING} chip_progress_logging=${PROGRESS_LOGGING}"
- name: Run Build
timeout-minutes: 10
run: scripts/build/gn_build.sh
Expand Down

0 comments on commit b9620ec

Please sign in to comment.