Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VS code setting for custom extension repository #180

Merged
merged 20 commits into from
Aug 24, 2024
Merged

Add VS code setting for custom extension repository #180

merged 20 commits into from
Aug 24, 2024

Conversation

Mateusz-Grzelinski
Copy link
Collaborator

@Mateusz-Grzelinski Mateusz-Grzelinski commented Aug 4, 2024 •
edited
Loading

In this PR: playing aroud with ideas from #176

  • Add setting to specify to which repository install addons from VS code
  • Implement sending settings from VS code to blender addon
    image

TODO:

  • pass data as env var to simplify communication via http server
  • update changelog, readme
  • ensure repo name is valid python module path

@Mateusz-Grzelinski
Add setting for custom extension repository
3e047d5 
Implement sending settings from VS code to blender addon
@Mateusz-Grzelinski Mateusz-Grzelinski changed the title Add setting for custom extension repository Add VS code setting for custom extension repository Aug 4, 2024
@Griperis
Copy link
Collaborator

Griperis commented Aug 5, 2024 •
edited
Loading

Idea to make this simpler: What if the extension setting sets an ENV VAR, that you can read in bpy afterwards, so you don't have to send the data between python and js?

@Mateusz-Grzelinski Mateusz-Grzelinski added this to the 0.0.22 milestone Aug 12, 2024
@Mateusz-Grzelinski Mateusz-Grzelinski marked this pull request as ready for review August 14, 2024 14:45
@Mateusz-Grzelinski
Merge remote-tracking branch 'refs/remotes/jack/master' into separate…
a0d4249 
…-extension-repo-setting

# Conflicts:
#	CHANGELOG.md
#	README.md
#	pythonFiles/include/blender_vscode/communication.py
#	pythonFiles/include/blender_vscode/load_addons.py
#	pythonFiles/include/blender_vscode/operators/addon_update.py
@Mateusz-Grzelinski
Use global variable
5c7c62b
@Mateusz-Grzelinski
Update changelog
d19418b
@Mateusz-Grzelinski
Better handling for settings
12950aa
@Mateusz-Grzelinski
Fix error after merge
32e3e2b
@Mateusz-Grzelinski
Copy link
Collaborator Author

works quite well, tested on windows, blender 2.8, 4.2.
If user changes name of repo it also works fine, but missing addons might be reported. Thanks to proper implementation of #172 we do not have duplicate links.
Also works fine when running multiple blender and the repo name was changed in a meantime.
If no feedback i will merge on the weekend

@Mateusz-Grzelinski Mateusz-Grzelinski merged commit ecaa827 into JacquesLucke:master Aug 24, 2024
@Mateusz-Grzelinski Mateusz-Grzelinski deleted the separate-extension-repo-setting branch August 24, 2024 10:46
@Mateusz-Grzelinski Mateusz-Grzelinski mentioned this pull request Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.22
Development

Successfully merging this pull request may close these issues.
2 participants
@Mateusz-Grzelinski @Griperis