Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #80: find correct python path for blender 2.92 and before #174

Merged

Conversation

Mateusz-Grzelinski
Copy link
Collaborator

@Mateusz-Grzelinski Mateusz-Grzelinski commented Jul 30, 2024

Blender 2.,80, 2.91, 2.93 failed to install because of wrong python path.

Most likely fixes #99 #93 #80 #31

  • improved finding python path for older versions
  • improved typehints to be compatible with python 3.7
  • added log for pip call
  • fixed debugpy issue when sys.executable is not pointing to python what causes timeout

Tested in basic way with different versions:

blender-2.80-windows64
blender-2.83.20-windows-x64
blender-2.90.1-windows64
blender-2.93.18-windows-x64
blender-3.0
blender-3.3.21-windows-x64
blender-3.5.1
blender-3.6.14-windows-x64
blender-4.2.0-windows-x64

can be squashed, just remember to iclude sensible merge message.

@JacquesLucke JacquesLucke merged commit 3ab796b into JacquesLucke:master Aug 2, 2024
@Mateusz-Grzelinski Mateusz-Grzelinski deleted the fix-python-path branch August 2, 2024 12:14
@CGArtPython
Copy link
Collaborator

@Mateusz-Grzelinski Out of curiosity, why are we improving typehints for Python 3.7 if Blender 2.8 had Python 3.10 ?

@Mateusz-Grzelinski
Copy link
Collaborator Author

Mateusz-Grzelinski commented Aug 7, 2024

what are you talking about?

>>> bpy.app.version
(2, 80, 75)

>>> import sys; sys.version
'3.7.0 (default, Aug 26 2018, 16:05:01) [MSC v.1900 64 bit (AMD64)]'
>>> bpy.app.version
(2, 83, 20)

>>> import sys; sys.version
'3.7.4 (default, Feb 17 2020, 16:23:28) [MSC v.1916 64 bit (AMD64)]'

syntax used for typehints in 3.10 is in some cases not compatible with 3.7. We can put it in quots though.

@CGArtPython
Copy link
Collaborator

CGArtPython commented Aug 8, 2024

Yeah,
Just realized my Blender 2.8 shortcut is booting a newer version of Blender. 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.0.15 could not install debugpy
3 participants