Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for Linearity #3449

Open
hrzhuang opened this issue May 29, 2023 · 8 comments
Open

Improve documentation for Linearity #3449

hrzhuang opened this issue May 29, 2023 · 8 comments
Labels
documentation Documentation of Drasil itself - how to install, how to use, build system etc. newcomers Good first issue to work on!

Comments

@hrzhuang
Copy link
Collaborator

Context: #3448

@hrzhuang hrzhuang added the documentation Documentation of Drasil itself - how to install, how to use, build system etc. label May 29, 2023
@samm82 samm82 added the newcomers Good first issue to work on! label May 30, 2023
@daijingz
Copy link
Contributor

@hrzhuang Can you give me more information?

@daijingz
Copy link
Contributor

daijingz commented Dec 21, 2023

Which documentation am I required to change? I guess it has to be SRS, however, then the second problem is, where is the position should I add it in? All sections do not have relevant content with this part of the code.
I guess it is elsewhere in the code, but I am unsure. @samm82

@samm82
Copy link
Collaborator

samm82 commented Jan 11, 2024

The issue title seems to be a bit misleading; I think the actual task here is that Linearity (see below) should be changed to something that makes more sense (following the linked issue), including its documentation (the comment above its definition).

-- | Data is either linear or not.
data Linearity = Linear | Nonlinear

@daijingz
Copy link
Contributor

@samm82 In this issue, I feel I only need to change documentation (nothing needed to change with the code) Is this correct?

@samm82
Copy link
Collaborator

samm82 commented Jan 12, 2024

That's what I meant by this comment:

The issue title seems to be a bit misleading; I think the actual task here is that Linearity should be changed to something that makes more sense (following the linked issue), including its documentation.

The main issue is actually to change the names of Linearity, Linear, and Nonlinear. Once these names (and the comment above them, its "documentation") are changed in their definition and wherever they're used, this shouldn't have an effect on the generated output.

@daijingz
Copy link
Contributor

@samm82 So there are two parts of work in this issue: change the code and the documentation.
For the code I am going to replace the definition name with this: data SingleLine = OneLine | MultiLine, while its corresponding comments need to be changed too. (Some of them still have references with the name "Linearity")
U`HN$99)(1CNTH@_K_O5P2I

({SK4U1 TOEZK4B`EQ96TRW

@daijingz
Copy link
Contributor

@samm82 For the second part (documentation), where is the corresponding documentation position for Linearity? I searched all documents in SRS, but I feel there are no occurrences of the word "Linearity". (Not only in the SRS, it does not occur elsewhere)

As you can see the evidence below, only one file contains "Linearity", and this file is not a documentation:
CC$SW8$TT(SA(VY JZ9Y7$3

@samm82
Copy link
Collaborator

samm82 commented Jan 18, 2024

Right, documentation can refer to "generated documentation for our code examples" OR "manual documentation for our Drasil code". This specific usage refers to the second, not the first; updating the comment above the definition of the new data SingleLine is what we're looking for

JacquesCarette added a commit that referenced this issue Jan 19, 2024
#3449 Improve documentation for Linearity (Part 1 Code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation of Drasil itself - how to install, how to use, build system etc. newcomers Good first issue to work on!
Projects
None yet
Development

No branches or pull requests

3 participants