Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): adding missing base types to the patch gen method #90

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

Jacobbrewer1
Copy link
Owner

@Jacobbrewer1 Jacobbrewer1 commented Jan 18, 2025

Describe your changes

This pull request includes changes to the sql.go and sql_test.go files to enhance the SQLPatch functionality and improve test coverage. The most important changes include adding support for more data types in the patchGen method and introducing a new test to verify this support.

Enhancements to SQLPatch functionality:

  • sql.go: Added support for unsigned integers, floating-point numbers, and complex numbers in the patchGen method. [1] [2]

Improvements to test coverage:

  • sql_test.go: Added a new test TestPatchGen_AllTypes to verify that the patchGen method correctly handles all supported data types.

@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) January 18, 2025 13:50
@Jacobbrewer1 Jacobbrewer1 disabled auto-merge January 18, 2025 13:51
@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) January 18, 2025 13:54
@Jacobbrewer1 Jacobbrewer1 merged commit 891b43f into main Jan 18, 2025
6 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the fix/base-types-gen branch January 18, 2025 13:54
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant