Repository navigation
fix(server): default base dir becomes ~/.j5code - #37
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted by an AI agent on Jackson's behalf
Problem
A bare J5 server or pairing command previously fell through to ~/.t3, colliding with a real T3 installation on the dogfood host.
Solution
Change the server fallback to ~/.j5code while preserving the existing precedence chain. Extend safety tooling to protect both installed homes, and make the SSH template follow the identity of the runner it launches.
Behavior changes
--base-dir>T3CODE_HOME> desktop bootstrap > built-in default remains unchanged.~/.j5codeand creates no~/.t3state.t3@*runners retain upstream~/.t3; developmentnodeScriptPathrunners use~/.j5code.~/.t3and~/.j5code.Change list
apps/server/src/os-jank.tsdefault and add discriminating config coverage.FORK.md; soften the dogfood warning and reclassify DQ5 indogfood-v0.md.Testing
os-jankanddev-runnerpassed.git diff --checkpassed.~/.t3and~/.j5codewere not touched. No browser/UI pass applies to this server-side path change; the discriminating tests are the proof.Deferrals, follow-ups & related work
Closes #33
Model/harness: GPT-5.6 Luna / Codex