Skip to content

fix(server): default base dir becomes ~/.j5code - #37

Merged
Jacksondr5 merged 3 commits into
j5/mainfrom
j5-dq5-default-base-dir
Aug 31, 2026
Merged

Jacksondr5 merged 3 commits into
j5/mainfrom
j5-dq5-default-base-dir

Conversation

@Jacksondr5

Copy link
Copy Markdown
Owner

Posted by an AI agent on Jackson's behalf

Problem

A bare J5 server or pairing command previously fell through to ~/.t3, colliding with a real T3 installation on the dogfood host.

Solution

Change the server fallback to ~/.j5code while preserving the existing precedence chain. Extend safety tooling to protect both installed homes, and make the SSH template follow the identity of the runner it launches.

Behavior changes

  • --base-dir > T3CODE_HOME > desktop bootstrap > built-in default remains unchanged.
  • A bare server uses ~/.j5code and creates no ~/.t3 state.
  • SSH npm t3@* runners retain upstream ~/.t3; development nodeScriptPath runners use ~/.j5code.
  • Dev/test database guards refuse both ~/.t3 and ~/.j5code.

Change list

  • Update apps/server/src/os-jank.ts default and add discriminating config coverage.
  • Align the dev-runner fallback/log label and pairing documentation.
  • Additive safety guards and both-home tests for delivery seeding, SQLite state, and dev-db migration.
  • Add runner-identity SSH launch/pairing templates and branch-specific tests.
  • Record the protected upstream edit and sweep evidence in FORK.md; soften the dogfood warning and reclassify DQ5 in dogfood-v0.md.

Testing

  • Five focused files: 33 tests passed.
  • 75 regression tests for os-jank and dev-runner passed.
  • Targeted lint, server/SSH typechecks, and git diff --check passed.
  • Negative controls killed the default, each safety guard path, and each SSH runner-home branch when mutated.
  • Tests used temporary homes only; live ~/.t3 and ~/.j5code were not touched. No browser/UI pass applies to this server-side path change; the discriminating tests are the proof.

Deferrals, follow-ups & related work

  • Nonblocking low review notes remain on the group board for optional follow-up.
  • CodeRabbit review will run once at the reviewer-clean READY head.

Closes #33

Model/harness: GPT-5.6 Luna / Codex

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7223d394-f881-452b-a1c5-5c739127fe00

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Aug 31, 2026
@Jacksondr5
Jacksondr5 merged commit 17cfbc6 into j5/main Aug 31, 2026
14 checks passed
@Jacksondr5
Jacksondr5 deleted the j5-dq5-default-base-dir branch August 31, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DQ5 — Server default base dir becomes ~/.j5code (stop defaulting into ~/.t3)

1 participant