Skip to content

Crew notice cards are not searchable with in-thread find #505

Closed as not planned

Description

@Jacksondr5

From the upstream advance (#500), which made agent-to-agent message cards take part in upstream's in-thread find.

Peer, sent and human message cards carry the find attribute. Crew notice cards (Crew launched, Seat finished and the rest) do not. Their visible text is partly generated presentation, not the stored notice, so the find index and what is on screen would not match if the attribute were simply added.

To decide: whether Crew notices should be findable, and if so which text is indexed.

Activity

  1. Jacksondr5 commented on Oct 10, 2026

    @Jacksondr5
    OwnerAuthor

    Looked at this on 2026-10-10 (j5/main at 553119ca24). Jackson's answer to the open question was "findable, by the on-screen text". That turns out not to be a small change.

    How upstream's find works. The server counts occurrences of the query in each entry's stored text (apps/server/src/orchestration-v2/ThreadFind.ts, unmodified by J5) and returns "entry X, occurrence N". The client then highlights the Nth occurrence it sees inside that row's data-thread-find-text elements (threadFindHighlights.ts). The two sides only agree when the text on screen is the stored text.

    Why Crew notices do not fit. A notice's stored text is a tagged block; the card shows words J5 generates from it ("Crew launched", seat names, counts). So:

    • a query for words on the card that are not in the stored block finds nothing, because the server never sees them;
    • a query that matches the stored block's tags or ids is counted by the server but has nothing on screen to highlight, and shifts which occurrence gets highlighted in that row.

    Searching the on-screen text would mean the server producing the notice's display text, or upstream's find accepting a per-entry display text. Either is a change to upstream's find, not an attribute on a J5 card.

    Agent-to-agent message cards have a mild form of the same mismatch (the stored envelope's header and instruction lines are not shown), accepted in #500 because the body is verbatim.

  2. Jacksondr5 commented on Oct 11, 2026

    @Jacksondr5
    OwnerAuthor

    Closing as not supported here (Jackson, 2026-10-11). Finding a notice by its on-screen text needs upstream's server-side find to accept an entry's display text, which is an upstream product change for a small gain; the messages around a notice are already findable. If it matters later, raise it upstream in that form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions