Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyOpenSci Review - Code Updates #155

Merged
merged 4 commits into from
Oct 11, 2023
Merged

PyOpenSci Review - Code Updates #155

merged 4 commits into from
Oct 11, 2023

Conversation

JacksonBurns
Copy link
Owner

This pull request contains updates to the source code as part of the PyOpenSci review (see pyOpenSci/software-submission#120).

Each commit message contains additional clarifying details.

 - clarified in the README that this is only intended for regression (we should add an equivalent for classification, with different default metrics, that would perhaps involve creating a new abstract function that both this function and the new one would call)
 - make more general by allowing users to pass in other metrics, or to include their own
This was referenced Sep 22, 2023
@BerylKanali
Copy link

I have gone through the commits and the issues/concerns they address and I believe you have addressed and explained everything well. I have no additional concerns on the code or functionality.
I have also added the comment here pyOpenSci/software-submission#120

Copy link

@BerylKanali BerylKanali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through the changes and the issues they address and I believe you have addressed all the major concerns.

@JacksonBurns JacksonBurns added the PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot label Oct 11, 2023
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@JacksonBurns
Copy link
Owner Author

3.12 support blocked by RDKit for the time being, will bypass:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage meets or exceeds 90% threshold (currently 97%).

@JacksonBurns JacksonBurns merged commit 8e3d1b5 into main Oct 11, 2023
35 of 46 checks passed
@JacksonBurns JacksonBurns deleted the pyopensci_code_updates branch October 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants