Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readme line to explain how to use MDKS #149

Merged
merged 1 commit into from
Jul 18, 2023
Merged

add readme line to explain how to use MDKS #149

merged 1 commit into from
Jul 18, 2023

Conversation

JacksonBurns
Copy link
Owner

Resolves #129 - see discussion there.

@JacksonBurns JacksonBurns added the PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot label Jul 17, 2023
@JacksonBurns
Copy link
Owner Author

The tests are failing because of issues with the runners, not the changes here. Let's give actions some time to fix themselves.

@JacksonBurns JacksonBurns assigned JacksonBurns and unassigned kspieks Jul 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage meets or exceeds 90% threshold (currently 98%).

@JacksonBurns
Copy link
Owner Author

@kspieks I fixed the issue - latest release of Cython was incompatible with PyYaml v5 over on AIMSim, released a new patch and everything is fine. Ready for review.

@JacksonBurns JacksonBurns requested review from kspieks and removed request for kspieks July 18, 2023 14:10
Copy link
Collaborator

@kspieks kspieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the addition

@kspieks kspieks merged commit f8ab231 into main Jul 18, 2023
24 checks passed
@JacksonBurns JacksonBurns deleted the mdks branch July 18, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Ready for Review Mark a PR as Ready for Review for the GitHub coverage checker bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Mahalanobis Distance Kennard-Stone (MDKS) Sampler
2 participants