Skip to content

Removes functionality for additional fields via XML file #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-kolb merged 1 commit into from
Aug 12, 2015
Merged

Removes functionality for additional fields via XML file #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions src/main/java/net/sf/jabref/BibtexFields.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@ public class BibtexFields {
public static final String OWNER = "owner";
public static final String TIMESTAMP = "timestamp"; // it's also definied at the JabRefPreferences class
private static final String ENTRYTYPE = "entrytype";

/*
* some extra field definitions
*/
private static final String ADDITIONAL_FIELDS = "/resource/fields/fields.xml";

public static final String// Using this when I have no database open or when I read
// non bibtex file formats (used by the ImportFormatReader.java)
Expand Down Expand Up @@ -244,9 +239,6 @@ private BibtexFields()
dummy.setDisplayable(false);
add(dummy);

// read external field definitions
readXML(ADDITIONAL_FIELDS);

// collect all public fields for the PUBLIC_FIELDS array
Vector<String> pFields = new Vector<String>(fieldSet.size());
for (BibtexSingleField sField : fieldSet.values()) {
Expand Down Expand Up @@ -302,34 +294,6 @@ private void add(BibtexSingleField field)
fieldSet.put(key, field);
}

/** read a xml definiton file and put only NEW fields into the field list */
private void readXML(String resName)
{
TXMLReader reader = new TXMLReader(resName);
if (reader.isReady())
{
// get a list of all fields
NodeList fieldNodes = reader.getNodes("field");

int tagsCount = fieldNodes.getLength();
for (int t = 0; t < tagsCount; t++)
{
Element entry = (Element) fieldNodes.item(t);
String fName = reader.readStringAttribute(entry, "name", null);
if (fName != null) // something found ?
{
fName = fName.toLowerCase();
BibtexSingleField dummy = fieldSet.get(fName);
if (dummy == null) // unknown field
{
dummy = new BibtexSingleField(reader, entry);
fieldSet.put(fName, dummy);
}
}
}
}
}

// --------------------------------------------------------------------------
// the "static area"
// --------------------------------------------------------------------------
Expand Down