Skip to content

Refactor context menu entry types changing #8957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Siedlerchr merged 3 commits into from
Jul 9, 2022
Merged

Refactor context menu entry types changing #8957

Siedlerchr merged 3 commits into from
Jul 9, 2022

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jul 6, 2022

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr changed the title Refactored Refactor context menu entry types changing Jul 6, 2022
@calixtus
Copy link
Member

calixtus commented Jul 6, 2022

Still issue:

java.lang.NullPointerException: Cannot invoke "javafx.scene.control.ContextMenu.getOwnerWindow()" because "this.contextMenu" is null
	at javafx.controls@18/com.sun.javafx.scene.control.ContextMenuContent.computeVisualMetrics(ContextMenuContent.java:236)
	at javafx.controls@18/com.sun.javafx.scene.control.ContextMenuContent.computePrefWidth(ContextMenuContent.java:378)
	at javafx.graphics@18/javafx.scene.Parent.prefWidth(Parent.java:1020)
	at javafx.graphics@18/javafx.scene.layout.Region.prefWidth(Region.java:1589)
	at javafx.graphics@18/javafx.scene.Parent.computePrefWidth(Parent.java:1092)
	at javafx.graphics@18/javafx.scene.layout.Region.computePrefWidth(Region.java:1684)
	at javafx.graphics@18/javafx.scene.Parent.prefWidth(Parent.java:1020)
	at javafx.graphics@18/javafx.scene.layout.Region.prefWidth(Region.java:1589)
	at javafx.graphics@18/javafx.scene.Parent.computePrefWidth(Parent.java:1092)
	at javafx.graphics@18/javafx.scene.layout.Region.computePrefWidth(Region.java:1684)
	at javafx.graphics@18/javafx.scene.Parent.prefWidth(Parent.java:1020)
	at javafx.graphics@18/javafx.scene.layout.Region.prefWidth(Region.java:1589)
	at javafx.graphics@18/javafx.scene.Scene.getPreferredWidth(Scene.java:1824)
	at javafx.graphics@18/javafx.scene.Scene.resizeRootToPreferredSize(Scene.java:1800)
	at javafx.graphics@18/javafx.scene.Scene$2$1.doLayoutPass(Scene.java:440)
	at javafx.graphics@18/javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2499)
	at javafx.graphics@18/com.sun.javafx.tk.Toolkit.lambda$runPulse$2(Toolkit.java:405)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at javafx.graphics@18/com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:404)
	at javafx.graphics@18/com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:434)
	at javafx.graphics@18/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:575)
	at javafx.graphics@18/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:555)
	at javafx.graphics@18/com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:548)
	at javafx.graphics@18/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:352)
	at javafx.graphics@18/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at javafx.graphics@18/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at javafx.graphics@18/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:316)
	at java.base/java.lang.Thread.run(Thread.java:833)

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Jul 9, 2022

Probably a weird javafx bug under linux

@Siedlerchr Siedlerchr merged commit 1e3160e into JabRef:main Jul 9, 2022
@Siedlerchr Siedlerchr deleted the refactor-entrytypemenu branch July 9, 2022 16:16
Siedlerchr added a commit that referenced this pull request Jul 10, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into detectCharset
cf59352 
* upstream/main:
  Keep UTF-8 encoding header if present (#8964)
  Cleanup index when opening a library (#8962)
  Refactor context menu entry types changing (#8957)
  Improvement on check for missing commas when importing or opening a .bib file (#8840)

# Conflicts:
#	src/test/java/org/jabref/logic/importer/fileformat/BibtexImporterTest.java
Siedlerchr added a commit that referenced this pull request Jul 14, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…
6b7dfa9 
…failure-dialog

* upstream/main: (76 commits)
  New Crowdin updates (#8972)
  New Crowdin updates (#8969)
  Fix .bat errorlevel handling with pwsh.exe check (#8965)
  revert jsoup version upgrade
  Fix charset detection with utf16 and others (#8947)
  Bump classgraph from 4.8.147 to 4.8.149 (#8968)
  Bump jsoup from 1.15.1 to 1.15.2 (#8967)
  Keep UTF-8 encoding header if present (#8964)
  Cleanup index when opening a library (#8962)
  Refactor context menu entry types changing (#8957)
  Improvement on check for missing commas when importing or opening a .bib file (#8840)
  Disable ResearchGateTest on CI (#8955)
  Bump checkstyle from 10.1 to 10.3.1 (#8950)
  Bump checkstyle from 10.1 to 10.3.1 (#8950)
  Bump mariadb-java-client from 2.7.5 to 2.7.6 (#8953)
  Add notification when adding previous entries to new group configuration (#8919)
  Remember Sidepane width after restart (#8936)
  move "Warn about duplicates on import" preferences option (#8937)
  Fix theme switching exception (#8939)
  fix merge conflict
  ...

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Jul 15, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8189
33de3cf 
* upstream/main: (28 commits)
  [Bot] Update CSL styles (JabRef#8978)
  New Crowdin updates (JabRef#8972)
  New Crowdin updates (JabRef#8969)
  Fix .bat errorlevel handling with pwsh.exe check (JabRef#8965)
  revert jsoup version upgrade
  Fix charset detection with utf16 and others (JabRef#8947)
  Bump classgraph from 4.8.147 to 4.8.149 (JabRef#8968)
  Bump jsoup from 1.15.1 to 1.15.2 (JabRef#8967)
  Keep UTF-8 encoding header if present (JabRef#8964)
  Cleanup index when opening a library (JabRef#8962)
  Refactor context menu entry types changing (JabRef#8957)
  Improvement on check for missing commas when importing or opening a .bib file (JabRef#8840)
  Disable ResearchGateTest on CI (JabRef#8955)
  Bump checkstyle from 10.1 to 10.3.1 (JabRef#8950)
  Bump checkstyle from 10.1 to 10.3.1 (JabRef#8950)
  Bump mariadb-java-client from 2.7.5 to 2.7.6 (JabRef#8953)
  Add notification when adding previous entries to new group configuration (JabRef#8919)
  Remember Sidepane width after restart (JabRef#8936)
  move "Warn about duplicates on import" preferences option (JabRef#8937)
  Fix theme switching exception (JabRef#8939)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: entry-editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @calixtus @ThiloteE