-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to copy the DOI to the copy sub-menu #7894
Conversation
Thank you for your interest in this issue, especially for thinking of the tests. |
I've completed the checklist, and everything seems right. The only problem is the checkstyle test failing, saying that there are 5 trailing spaces in CHANGELOG.md, but my change doesn't appear to add any trailing spaces. I'm not sure what to do to fix that. |
@@ -40,6 +40,7 @@ | |||
private BibEntry entry; | |||
private List<String> titles = new ArrayList<String>(); | |||
private List<String> keys = new ArrayList<String>(); | |||
private List<String> DOIs = new ArrayList<String>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variabl names should be all lowerCamelCase, e.g dois
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one minor nitpicking.
Thanks for the quick follow up. Looks good from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, one thing that could be improved in a future PR is making the executable binding dependant on if there is a doi present.
Thanks for your contribution to JabRef! |
Adds the feature requested in
Fixes #7826
Screenshot:
.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)