Code style

src/main/java/net/sf/jabref/AdvancedTab.java

@@ -61,8 +61,8 @@ public class AdvancedTab extends JPanel implements PrefsTab {
     private boolean oldBiblMode = false;
     private int oldPort = -1;
 
-    public final static String PREF_IMPORT_CONVERT_TO_EQUATION = "importFileConvertToEquation";
-    public final static String PREF_IMPORT_FILENAMEPATTERN = "importFileNamePattern";
+    public static final String PREF_IMPORT_CONVERT_TO_EQUATION = "importFileConvertToEquation";
+    public static final String PREF_IMPORT_FILENAMEPATTERN = "importFileNamePattern";
 
     private final JCheckBox useConvertToEquation;
     private final JCheckBox useCaseKeeperOnSearch;

src/main/java/net/sf/jabref/AppearancePrefsTab.java

@@ -228,17 +228,16 @@ private boolean validateIntegerField(String fieldName, String fieldValue, String
     @Override
     public boolean readyToClose() {
         // Test if font size is a number:
-        if (validateIntegerField("Menu and label font size", fontSize.getText(), "Changed font settings") == false) {
+        if (!validateIntegerField("Menu and label font size", fontSize.getText(), "Changed font settings")) {
             return false;
         }
 
         // Test if row padding is a number:
-        if (validateIntegerField("Table row height padding", rowPadding.getText(), "Changed table appearance settings") == false) {
+        if (!validateIntegerField("Table row height padding", rowPadding.getText(), "Changed table appearance settings")) {
             return false;
         }
 
         return true;
-
     }
 
     @Override

src/main/java/net/sf/jabref/BasePanel.java

@@ -141,10 +141,10 @@ public class BasePanel extends JPanel implements ClipboardOwner, FileUpdateListe
 
     private static final Log LOGGER = LogFactory.getLog(BasePanel.class);
 
-    public final static int SHOWING_NOTHING = 0;
-    private final static int SHOWING_PREVIEW = 1;
-    public final static int SHOWING_EDITOR = 2;
-    public final static int WILL_SHOW_EDITOR = 3;
+    public static final int SHOWING_NOTHING = 0;
+    private static final int SHOWING_PREVIEW = 1;
+    public static final int SHOWING_EDITOR = 2;
+    public static final int WILL_SHOW_EDITOR = 3;
 
     /* 
      * The database shown in this panel.

src/main/java/net/sf/jabref/BibtexEntry.java

@@ -49,7 +49,7 @@
 public class BibtexEntry
 {
 
-    private final static String ID_FIELD = "id";
+    private static final String ID_FIELD = "id";
     public static final Map<String, String> FieldAliasesOldToNew = new HashMap<String, String>(); // Bibtex to BibLatex
     public static final Map<String, String> FieldAliasesNewToOld = new HashMap<String, String>(); // BibLatex to Bibtex
 

src/main/java/net/sf/jabref/DuplicateCheck.java

@@ -27,14 +27,14 @@ public class DuplicateCheck {
      * Integer values for indicating result of duplicate check (for entries):
      *
      */
-    final static int NOT_EQUAL = 0, EQUAL = 1, EMPTY_IN_ONE = 2, EMPTY_IN_TWO = 3, EMPTY_IN_BOTH = 4;
+    static final int NOT_EQUAL = 0, EQUAL = 1, EMPTY_IN_ONE = 2, EMPTY_IN_TWO = 3, EMPTY_IN_BOTH = 4;
 
     public static double duplicateThreshold = 0.75; // The overall threshold to signal a duplicate pair
     // Non-required fields are investigated only if the required fields give a value within
     // the doubt range of the threshold:
     private static final double doubtRange = 0.05;
 
-    private final static double reqWeight = 3; // Weighting of all required fields
+    private static final double reqWeight = 3; // Weighting of all required fields
 
     // Extra weighting of those fields that are most likely to provide correct duplicate detection:
     private static final HashMap<String, Double> fieldWeights = new HashMap<String, Double>();

src/main/java/net/sf/jabref/FieldTextArea.java

@@ -38,9 +38,9 @@ public class FieldTextArea extends JTextAreaWithHighlighting implements FieldEdi
 
     private String fieldName;
 
-    final static Pattern bull = Pattern.compile("\\s*[-\\*]+.*");
+    static final Pattern bull = Pattern.compile("\\s*[-\\*]+.*");
 
-    final static Pattern indent = Pattern.compile("\\s+.*");
+    static final Pattern indent = Pattern.compile("\\s+.*");
 
     private AutoCompleteListener autoCompleteListener = null;
 

src/main/java/net/sf/jabref/IdGenerator.java

@@ -9,7 +9,7 @@
  */
 public class IdGenerator {
 
-    private final static NumberFormat idFormat;
+    private static final NumberFormat idFormat;
 
     static {
         idFormat = NumberFormat.getInstance();
@@ -19,7 +19,7 @@ public class IdGenerator {
 
     private static int idCounter = 0;
 
-    public synchronized static String next() {
+    public static synchronized String next() {
         String result = idFormat.format(idCounter);
         idCounter++;
         return result;

src/main/java/net/sf/jabref/ImportSettingsTab.java

@@ -28,16 +28,16 @@
 
 public class ImportSettingsTab extends JPanel implements PrefsTab {
 
-    public final static String PREF_IMPORT_ALWAYSUSE = "importAlwaysUsePDFImportStyle";
-    public final static String PREF_IMPORT_DEFAULT_PDF_IMPORT_STYLE = "importDefaultPDFimportStyle";
-    public final static int DEFAULT_STYLE = ImportDialog.CONTENT;
+    public static final String PREF_IMPORT_ALWAYSUSE = "importAlwaysUsePDFImportStyle";
+    public static final String PREF_IMPORT_DEFAULT_PDF_IMPORT_STYLE = "importDefaultPDFimportStyle";
+    public static final int DEFAULT_STYLE = ImportDialog.CONTENT;
 
-    public final static String PREF_IMPORT_FILENAMEPATTERN = "importFileNamePattern";
-    private final static String[] DEFAULT_FILENAMEPATTERNS_DISPLAY = new String[] {
+    public static final String PREF_IMPORT_FILENAMEPATTERN = "importFileNamePattern";
+    private static final String[] DEFAULT_FILENAMEPATTERNS_DISPLAY = new String[] {
             "bibtexkey",
             "bibtexkey - title",
     };
-    public final static String[] DEFAULT_FILENAMEPATTERNS = new String[] {
+    public static final String[] DEFAULT_FILENAMEPATTERNS = new String[] {
             "\\bibtexkey",
             "\\bibtexkey\\begin{title} - \\format[RemoveBrackets]{\\title}\\end{title}"
     };

src/main/java/net/sf/jabref/JabRefPreferences.java

@@ -151,7 +151,7 @@ public class JabRefPreferences {
     public static final String NUMBER_COL_WIDTH = "numberColWidth";
     public static final String SHORTEST_TO_COMPLETE = "shortestToComplete";
     public static final String AUTOCOMPLETE_FIRSTNAME_MODE = "autoCompFirstNameMode";
-    public final static String AUTOCOMPLETE_FIRSTNAME_MODE_BOTH = "both"; // here are the possible values for _MODE:
+    public static final String AUTOCOMPLETE_FIRSTNAME_MODE_BOTH = "both"; // here are the possible values for _MODE:
     public static final String AUTO_COMP_LAST_FIRST = "autoCompLF";
     public static final String AUTO_COMP_FIRST_LAST = "autoCompFF";
     public static final String AUTO_COMPLETE_FIELDS = "autoCompleteFields";
@@ -319,8 +319,8 @@ public class JabRefPreferences {
     public static final String SELECTED_FETCHER_INDEX = "selectedFetcherIndex";
     public static final String WEB_SEARCH_VISIBLE = "webSearchVisible";
     public static final String ALLOW_FILE_AUTO_OPEN_BROWSE = "allowFileAutoOpenBrowse";
-    public final static String CUSTOM_TAB_NAME = "customTabName_";
-    public final static String CUSTOM_TAB_FIELDS = "customTabFields_";
+    public static final String CUSTOM_TAB_NAME = "customTabName_";
+    public static final String CUSTOM_TAB_FIELDS = "customTabFields_";
     public static final String USER_FILE_DIR_INDIVIDUAL = "userFileDirIndividual";
     public static final String USER_FILE_DIR_IND_LEGACY = "userFileDirInd_Legacy";
     public static final String USER_FILE_DIR = "userFileDir";
@@ -330,13 +330,13 @@ public class JabRefPreferences {
     public static final String USE_IEEE_ABRV = "useIEEEAbrv";
 
     //non-default preferences
-    private final static String CUSTOM_TYPE_NAME = "customTypeName_";
-    private final static String CUSTOM_TYPE_REQ = "customTypeReq_";
-    private final static String CUSTOM_TYPE_OPT = "customTypeOpt_";
-    private final static String CUSTOM_TYPE_PRIOPT = "customTypePriOpt_";
-    public final static String PDF_PREVIEW = "pdfPreview";
-    public final static String AUTOCOMPLETE_FIRSTNAME_MODE_ONLY_FULL = "fullOnly";
-    public final static String AUTOCOMPLETE_FIRSTNAME_MODE_ONLY_ABBR = "abbrOnly";
+    private static final String CUSTOM_TYPE_NAME = "customTypeName_";
+    private static final String CUSTOM_TYPE_REQ = "customTypeReq_";
+    private static final String CUSTOM_TYPE_OPT = "customTypeOpt_";
+    private static final String CUSTOM_TYPE_PRIOPT = "customTypePriOpt_";
+    public static final String PDF_PREVIEW = "pdfPreview";
+    public static final String AUTOCOMPLETE_FIRSTNAME_MODE_ONLY_FULL = "fullOnly";
+    public static final String AUTOCOMPLETE_FIRSTNAME_MODE_ONLY_ABBR = "abbrOnly";
 
     // This String is used in the encoded list in prefs of external file type
     // modifications, in order to indicate a removed default file type:

src/main/java/net/sf/jabref/PreambleEditor.java

@@ -37,7 +37,6 @@ public PreambleEditor(JabRefFrame baseFrame,
             BasePanel panel, BibtexDatabase base,
             JabRefPreferences prefs) {
         super(baseFrame);
-        JabRefFrame baseFrame1 = baseFrame;
         this.panel = panel;
         this.base = base;
         this.prefs = prefs;

src/main/java/net/sf/jabref/autocompleter/AbstractAutoCompleter.java

@@ -46,7 +46,7 @@ abstract class AbstractAutoCompleter implements AutoCompleter {
 
 
 
-    abstract public void addBibtexEntry(BibtexEntry entry);
+    public abstract void addBibtexEntry(BibtexEntry entry);
 
     /**
      * Returns one or more possible completions for a given String. The returned

src/main/java/net/sf/jabref/export/layout/format/Authors.java

@@ -78,18 +78,18 @@ public class Authors extends AbstractParamLayoutFormatter {
 
     }
 
-    private final static int
+    private static final int
             FIRST_FIRST = 0;
-    private final static int LAST_FIRST = 1;
-    private final static int LF_FF = 2;
+    private static final int LAST_FIRST = 1;
+    private static final int LF_FF = 2;
 
-    private final static String
+    private static final String
             COMMA = ", ";
-    private final static String AMP = " & ";
-    private final static String COLON = ": ";
-    private final static String SEMICOLON = "; ";
-    private final static String AND = " and ";
-    private final static String OXFORD = ", and ";
+    private static final String AMP = " & ";
+    private static final String COLON = ": ";
+    private static final String SEMICOLON = "; ";
+    private static final String AND = " and ";
+    private static final String OXFORD = ", and ";
 
     private int flMode = Authors.FIRST_FIRST;
 

src/main/java/net/sf/jabref/export/layout/format/WrapFileLinks.java

@@ -227,7 +227,7 @@ private String replaceStrings(String text) {
     private static final int RELATIVE_FILE_PATH = 6;
 
     // Define which escape sequences give what results:
-    private final static Map<Character, Integer> ESCAPE_SEQ = new HashMap<Character, Integer>();
+    private static final Map<Character, Integer> ESCAPE_SEQ = new HashMap<Character, Integer>();
 
     static {
         WrapFileLinks.ESCAPE_SEQ.put('i', WrapFileLinks.ITERATION_COUNT);

src/main/java/net/sf/jabref/external/PushToEmacs.java

@@ -114,7 +114,7 @@ public void pushEntries(BibtexDatabase database, BibtexEntry[] entries, String k
         couldNotConnect = false;
         couldNotRunClient = false;
         String command = Globals.prefs.get(JabRefPreferences.EMACS_PATH);
-        String addParams[] = Globals.prefs.get(JabRefPreferences.EMACS_ADDITIONAL_PARAMETERS).split(" ");
+        String[] addParams = Globals.prefs.get(JabRefPreferences.EMACS_ADDITIONAL_PARAMETERS).split(" ");
         try {
             String[] com = new String[addParams.length + 2];
             com[0] = command;

src/main/java/net/sf/jabref/groups/EntryTableTransferHandler.java

@@ -205,7 +205,7 @@ public boolean importData(JComponent comp, Transferable t) {
 
         // all supported flavors failed
         System.err.println("can't transfer input: ");
-        DataFlavor inflavs[] = t.getTransferDataFlavors();
+        DataFlavor[] inflavs = t.getTransferDataFlavors();
         for (DataFlavor inflav : inflavs) {
             System.out.println("  " + inflav.toString());
         }

src/main/java/net/sf/jabref/imports/BibTeXMLHandler.java

@@ -62,7 +62,7 @@ public void endDocument() {
     }
 
     @Override
-    public void characters(char ch[], int start, int length) {
+    public void characters(char[] ch, int start, int length) {
         String s = new String(ch, start, length).trim();
         currentChars += s;
     }

src/main/java/net/sf/jabref/imports/CiteSeerXFetcher.java

@@ -32,11 +32,11 @@
 public class CiteSeerXFetcher implements EntryFetcher {
 
     private static final int MAX_PAGES_TO_LOAD = 8;
-    private final static String QUERY_MARKER = "___QUERY___";
-    private final static String URL_START = "http://citeseer.ist.psu.edu";
-    private final static String SEARCH_URL = CiteSeerXFetcher.URL_START + "/search?q=" + CiteSeerXFetcher.QUERY_MARKER
+    private static final String QUERY_MARKER = "___QUERY___";
+    private static final String URL_START = "http://citeseer.ist.psu.edu";
+    private static final String SEARCH_URL = CiteSeerXFetcher.URL_START + "/search?q=" + CiteSeerXFetcher.QUERY_MARKER
             + "&submit=Search&sort=rlv&t=doc";
-    private final static Pattern CITE_LINK_PATTERN = Pattern.compile("<a class=\"remove doc_details\" href=\"(.*)\">");
+    private static final Pattern CITE_LINK_PATTERN = Pattern.compile("<a class=\"remove doc_details\" href=\"(.*)\">");
 
     private boolean stopFetching = false;
 
@@ -132,11 +132,11 @@ private String getCitationsFromUrl(String urlQuery, List<String> ids) throws IOE
     }
 
 
-    private final static String basePattern = "<meta name=\"" + CiteSeerXFetcher.QUERY_MARKER + "\" content=\"(.*)\" />";
-    private final static Pattern titlePattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_title"));
-    private final static Pattern authorPattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_authors"));
-    private final static Pattern yearPattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_year"));
-    private final static Pattern abstractPattern = Pattern.compile("<h3>Abstract</h3>\\s*<p>(.*)</p>");
+    private static final String basePattern = "<meta name=\"" + CiteSeerXFetcher.QUERY_MARKER + "\" content=\"(.*)\" />";
+    private static final Pattern titlePattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_title"));
+    private static final Pattern authorPattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_authors"));
+    private static final Pattern yearPattern = Pattern.compile(CiteSeerXFetcher.basePattern.replace(CiteSeerXFetcher.QUERY_MARKER, "citation_year"));
+    private static final Pattern abstractPattern = Pattern.compile("<h3>Abstract</h3>\\s*<p>(.*)</p>");
 
 
     private BibtexEntry getSingleCitation(String urlString) throws IOException {

src/main/java/net/sf/jabref/imports/CsaImporter.java

@@ -44,19 +44,19 @@ public class CsaImporter extends ImportFormat {
     private int line;
 
     // pre-compiled patterns
-    private final static Pattern FIELD_PATTERN =
+    private static final Pattern FIELD_PATTERN =
             Pattern.compile("^([A-Z][A-Z]): ([A-Z].*)$");
-    private final static Pattern VOLNOPP_PATTERN =
+    private static final Pattern VOLNOPP_PATTERN =
             Pattern.compile("[;,\\.]\\s+(\\d+[A-Za-z]?)\\((\\d+(?:-\\d+)?)\\)(?:,\\s+|:)(\\d+-\\d+)");
-    private final static Pattern PAGES_PATTERN =
+    private static final Pattern PAGES_PATTERN =
             Pattern.compile("[;,\\.]\\s+(?:(\\[?[vn]\\.?p\\.?\\]?)|(?:pp?\\.?\\s+)(\\d+[A-Z]?(?:-\\d+[A-Z]?)?)|(\\d+[A-Z]?(?:-\\d+[A-Z]?)?)(?:\\s+pp?))");
-    private final static Pattern VOLUME_PATTERN =
+    private static final Pattern VOLUME_PATTERN =
             Pattern.compile("[;,\\.]?\\s+[vV][oO][lL]\\.?\\s+(\\d+[A-Z]?(?:-\\d+[A-Z]?)?)");
-    private final static Pattern NUMBER_PATTERN =
+    private static final Pattern NUMBER_PATTERN =
             Pattern.compile("[;,\\.]\\s+(?:No|no|Part|part|NUMB)\\.?\\s+([A-Z]?\\d+(?:[/-]\\d+)?)");
-    private final static Pattern DATE_PATTERN =
+    private static final Pattern DATE_PATTERN =
             Pattern.compile("[;,\\.]\\s+(?:(\\d+)\\s)?(?:([A-Z][a-z][a-z])[\\.,]*\\s)?\\(?(\\d\\d\\d\\d)\\)?(?:\\s([A-Z][a-z][a-z]))?(?:\\s+(\\d+))?");
-    private final static Pattern LT_PATTERN =
+    private static final Pattern LT_PATTERN =
             Pattern.compile("\\[Lt\\]");
 
     // other constants

src/main/java/net/sf/jabref/imports/DBLPFetcher.java

@@ -32,9 +32,9 @@
 
 public class DBLPFetcher implements EntryFetcher {
 
-    private final static String URL_START = "http://www.dblp.org/search/api/";
-    private final static String URL_PART1 = "?q=";
-    private final static String URL_END = "&h=1000&c=4&f=0&format=json";
+    private static final String URL_START = "http://www.dblp.org/search/api/";
+    private static final String URL_PART1 = "?q=";
+    private static final String URL_END = "&h=1000&c=4&f=0&format=json";
 
     private volatile boolean shouldContinue = false;
     private String query;

src/main/java/net/sf/jabref/imports/ImportMenuItem.java

@@ -73,7 +73,7 @@ public void actionPerformed(ActionEvent e) {
      * Automatically imports the files given as arguments
      * @param filenames List of files to import
      */
-    public void automatedImport(String filenames[]) {
+    public void automatedImport(String[] filenames) {
         // replace the work of the init step:
         MyWorker worker = new MyWorker();
         worker.fileOk = true;

src/main/java/net/sf/jabref/imports/IsiImporter.java

@@ -105,7 +105,7 @@ public boolean isRecognizedFormat(InputStream stream) throws IOException {
     private static final Pattern subsupPattern = Pattern.compile("/(sub|sup)\\s+(.*?)\\s*/");
 
 
-    static public void processSubSup(HashMap<String, String> map) {
+    public static void processSubSup(HashMap<String, String> map) {
 
         String[] subsup = {"title", "abstract", "review", "notes"};
 

src/main/java/net/sf/jabref/imports/JSTORFetcher2.java

@@ -141,7 +141,7 @@ private List<String> getCitations(String query, ImportInspector dialog, OutputPr
         try {
             urlQuery = JSTORFetcher2.SEARCH_URL + URLEncoder.encode(query, "UTF-8") + JSTORFetcher2.SEARCH_URL_END;
             int count = 1;
-            String numberOfRefs[] = new String[2];
+            String[] numberOfRefs = new String[2];
             int refsRequested;
             int numberOfPagesRequested = JSTORFetcher2.MAX_PAGES_TO_LOAD;
 

src/main/java/net/sf/jabref/imports/OvidImporter.java

@@ -110,7 +110,7 @@ public List<BibtexEntry> importEntries(InputStream stream, OutputPrinter status)
             sb.append('\n');
         }
 
-        String items[] = sb.toString().split("<[0-9]+>");
+        String[] items = sb.toString().split("<[0-9]+>");
 
         for (int i = 1; i < items.length; i++) {
             HashMap<String, String> h = new HashMap<String, String>();

src/main/java/net/sf/jabref/imports/RepecNepImporter.java

@@ -161,7 +161,7 @@ public class RepecNepImporter extends ImportFormat {
 
     private static final Log LOGGER = LogFactory.getLog(RepecNepImporter.class);
 
-    private final static Collection<String> recognizedFields = Arrays.asList("Keywords", "JEL", "Date", "URL", "By");
+    private static final Collection<String> recognizedFields = Arrays.asList("Keywords", "JEL", "Date", "URL", "By");
 
     private int line = 0;
     private String lastLine = "";

src/main/java/net/sf/jabref/imports/ScifinderImporter.java

@@ -99,7 +99,7 @@ public List<BibtexEntry> importEntries(InputStream stream, OutputPrinter status)
             hm.clear(); // reset
             for (String field : fields) {
                 if (field.contains(":")) {
-                    String tmp[] = new String[2];
+                    String[] tmp = new String[2];
                     tmp[0] = field.substring(0, field.indexOf(":"));
                     tmp[1] = field.substring(field.indexOf(":") + 1).trim();
                     if (tmp.length > 1) {//==2

src/main/java/net/sf/jabref/labelPattern/ResolveDuplicateLabelDialog.java

@@ -36,7 +36,7 @@ class ResolveDuplicateLabelDialog {
     private final List<JCheckBox> cbs = new ArrayList<JCheckBox>();
     private boolean okPressed = false;
 
-    private final static String layout = "<font face=\"arial\"><b><i>\\bibtextype</i><a name=\"\\bibtexkey\">\\begin{bibtexkey} (\\bibtexkey)</a>\\end{bibtexkey}</b><br>\n" +
+    private static final String layout = "<font face=\"arial\"><b><i>\\bibtextype</i><a name=\"\\bibtexkey\">\\begin{bibtexkey} (\\bibtexkey)</a>\\end{bibtexkey}</b><br>\n" +
             "\\begin{author} \\format[HTMLChars,AuthorAbbreviator,AuthorAndsReplacer]{\\author}<BR>\\end{author}\n" +
             "\\begin{editor} \\format[HTMLChars,AuthorAbbreviator,AuthorAndsReplacer]{\\editor} <i>(\\format[IfPlural(Eds.,Ed.)]{\\editor})</i><BR>\\end{editor}\n" +
             "\\begin{title} \\format[HTMLChars]{\\title} \\end{title}<BR>\n" +