Skip to content

Removed menu entry for 'Manage external file types' #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2020
Merged

Removed menu entry for 'Manage external file types' #7009

merged 1 commit into from
Oct 18, 2020

Conversation

schrothbn
Copy link
Contributor

Fixes #6991
Removed the menu entry to only have one way to access 'Manage external file types' in the Preferences Dialog

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

screenshot-6991

koppor
koppor requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to JabRef development and welcome to #hacktoberfest.

Small nitpicks, then it is good to go from my side.

@schrothbn
Copy link
Contributor Author

Welcome to JabRef development and welcome to #hacktoberfest.

Small nitpicks, then it is good to go from my side.
@koppor
Thank you very much for the nice welcome and your review.
Sorry I completely missed the unused import.
I think I resolved now everything you mentioned.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 17, 2020
Siedlerchr
Siedlerchr approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! It would also be nice if you could adjust the documentation:
https://docs.jabref.org/setup/externalfiletypes (just click on "Edit at Github")

calixtus
calixtus approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Siedlerchr Siedlerchr merged commit 1ff88cb into JabRef:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor requested changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: two menus for "Manage external file types"
4 participants
@schrothbn @Siedlerchr @koppor @calixtus