Fixes several FindBugs warnings and improve code quality #61
Conversation
There was a problem hiding this comment.
please delete field if it is unused instead of adding a warning.
|
I fixed the aspects mentioned above |
There was a problem hiding this comment.
Shouldn't be this action just offered in a menu than just being removed?
There was a problem hiding this comment.
As this class is not part of the shipped product because it is never called, we have no knowledge wether this feature works or not.
I would delete this as well. Reasoning: slime done and becoming productive again is better than adding any features that may contain bugs and we are also not certain whether the user really want such features.
There was a problem hiding this comment.
Shouldn't "brokenLinks" be output somehow than just be silently ignored?
There was a problem hiding this comment.
We could log this as a warning.
|
e8fec29 adds logging code for broken links. |
3 participants
I ran Findbugs on the source tree, had a look at several of the warnings and fixed those that were fixable from my point of view. When I touched a class, I also tried to eliminate Eclipse warnings if they were present.
This is really just a minor bump in code quality. Many warnings remain to be fixed.