Improve drag and drop #5306
Merged
Improve drag and drop #5306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
koppor
reviewed
Sep 12, 2019
|
Please check the "File" menu. We IMHO should be consistent in the whole
app... - We could replace "Open library" again with "Open file". However,
"file" does not work with Medline/... -- does your drop work with Medline
(auto import 😍), then "file" is OK for me!
Tobias Diez <notifications@github.com> schrieb am Fr., 13. Sep. 2019, 23:35:
… ***@***.**** commented on this pull request.
------------------------------
In src/main/java/org/jabref/gui/JabRefFrame.java
<#5306 (comment)>:
> @@ -246,6 +224,57 @@ public void init() {
initShowTrackingNotification();
}
+ public void initDragAndDrop() {
+ Tab dndIndicator = new Tab(Localization.lang("Open files..."), null);
That's a valid suggestion and I thought a bit about it. In the end, I
prefer "open files" since it makes the action clearer for the user: she
drops files into JabRef where they end up as new libraries.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5306?email_source=notifications&email_token=AAKNU7TJM6KJWS3BMFDI65LQJQBSFA5CNFSM4IVXZECKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEXISDI#discussion_r324376324>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKNU7SLZIG3K5LWFPMKXH3QJQBSFANCNFSM4IVXZECA>
.
|
|
@koppor Open LIbrary is restricted to .bib files |
Siedlerchr
added a commit
that referenced
this pull request
Sep 14, 2019
* upstream/master: Improve drag and drop (#5306)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve drag & drop by providing the user with visual feedback what the target of the action is and suggests what the action is. Fixes #5017.
Open files by dropping them on the tab header:
Linking a file to an entry by dropping it onto the entry:
Create new entry based on file by dropping it between entries (or at the beginning/end of the list):
