Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Oct 26, 2015

When selecting two entries, the context menu should offer merging of them, too.

  • When only one entry is selected, the "Merge entries" entry should be disabled.

@simonharrer
Copy link
Contributor

Good idea.

The options in the right click menu are getting more and more. What happens when the right-click menu is larger (higher) and the current screen?

If you do a rebase you can get rid of the merge commit in that case.

@koppor koppor force-pushed the enable-merge-entries-at-context-menu branch from 05a3606 to 83e1559 Compare October 26, 2015 06:50
@koppor koppor force-pushed the enable-merge-entries-at-context-menu branch from 83e1559 to 528083d Compare October 26, 2015 06:53
@oscargus
Copy link
Contributor

I think that there are also some other entries in the right-click menu which does not disable themselves as they should (if I recall correctly from adding the Merge from DOI). Just saying that it may be worthwhile taking a step back and see how the right-click menu behaves. The mark/unmark functionality is a bit inconsistent. Sometimes I get "Unmark entry", even though the entry is unmarked. Some commands, like "Open URL or DOI" and "Get Bibtex data from DOI" doesn't work with multiple entries selected although there is a rather obvious solution to how it should work.

Regarding to large menu, the three special copy-commands could be moved into a submenu, "Copy special". Would at least help a bit...

@simonharrer
Copy link
Contributor

👍 for having a close look at the disable/enable logic for the menu/taskbar/right-click-menu. We probably can delete a lot of duplicate code and make the code also more explicit.

Yes, this could help. But it also introduces another step to click them. Always these trade-offs.... :)

@simonharrer
Copy link
Contributor

I am against merging in a hack. Either this is improved or we close this.

@koppor koppor closed this Dec 15, 2015
@stefan-kolb stefan-kolb deleted the enable-merge-entries-at-context-menu branch December 15, 2015 22:16
koppor pushed a commit that referenced this pull request Jul 1, 2022
55459cd79f copied .github/workflows/merge.yaml .github/workflows/sheldon.yaml from styles
63eed7b271 copied .github/workflows/merge.yaml .github/workflows/sheldon.yaml from styles
39e1b29d16 copied .github/workflows/sheldon.yaml from styles
1b0a9d2f12 copied .github/workflows/sheldon.yaml from styles
9c4984cabd Merge pull request #261 from citation-style-language/dependabot/bundler/diffy-3.4.2
21387b3689 Bump diffy from 3.4.0 to 3.4.2

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: 55459cd79fa909bd0a11da509f109b2ddf4726e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants