-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add follow-up questions feature to AI chat #14354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implement automatic generation of follow-up questions after AI responses in the chat interface. Users can click suggested questions to continue the conversation naturally. Changes: - Add Generate follow-up questions setting in AI preferences - Create FollowUpQuestionGenerator to generate questions via AI - Update AiChatLogic to generate questions after each response - Display clickable follow-up question links in chat UI - Clear questions when new message is sent
Implement automatic generation of follow-up questions after AI responses in the chat interface. Users can click suggested questions to continue the conversation naturally. Changes: - Add Generate follow-up questions setting in AI preferences - Create FollowUpQuestionGenerator to generate questions via AI - Update AiChatLogic to generate questions after each response - Display clickable follow-up question links in chat UI - Clear questions when new message is sent # Conflicts: # jablib/src/main/resources/csl-styles
…bref into fix-for-issue-12243
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
What would anyone think about this: I think there are too many buttons for questions. What if we could hide "Try these examples" as soon as there are follow up questions? |
|
Okay, good! But the follow up questions template must be an |
I will limit the number of generated follow-up questions to three by default and will try to add the preference for users too.
I would be happy to look into adding this in a follow-up PR. |
Thanks, I will update the follow-up questions to use an |
…mplate - Default follow-up questions at 3 - New user preference to configure maximum number - Converted prompt to AiTemplate for consistency
…bref into fix-for-issue-12243
|
I have implemented these changes:
I have not worked on this part yet. If you would like me to include it in this PR, please let me know and I will be happy to update it. |
…runInJavaFXThread
|
I have implemented these changes:
Let me know if anything else is needed! |
InAnYan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks okay
jablib/src/main/java/org/jabref/logic/ai/templates/AiTemplate.java
Outdated
Show resolved
Hide resolved
…java to replace ',' with '.' in a comment Co-authored-by: Ruslan <ruslanpopov1512@gmail.com>
InAnYan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the UI in settings like this:
- Remove the word
Automatically. JustGenerate follow-up questions - And when the checkbox is not ticked, please disable the number input component, and, if possible, gray out the label "Number of follow-up questions"
The button Reset current template for follow-up questions template doesn't work.
Can you please add colons to Try with examples (Try with examples:) and the same for follow-up questions?
And when there are follow-up questions, can you hide the HBox with example questions?
|
But overall, it looks great! Thank you! |
Replying to @koppor . I think Generation of follow-up questions already implies that they are generated automatically. Though... maybe I was wrong with the wording "Automatically generate embeddings". Need to dive more |
|
I tested more, and found that hover is also available. Cool! |
I just want to clarify whether this should be done in this PR or in a separate PR, because @koppor commented earlier:
If I am mixing up two different things, please let me know. |
|
Ah, sorry, now I understand your confusion. But, IMHO, the review comments that are left are one-liners, so I think it's not hard to incorporate them in this PR |
Thanks for the clarification. I'll add it in this PR. |
I mis-read your question. Please include it here. |
- Remove Automatically from the follow-up questions setting - Disable numeric input and gray label when the checkbox is unchecked - Fix the reset template button - Add colons to Try with examples and Follow-up questions - Hide example questions HBox when follow-up questions are visible
…bref into fix-for-issue-12243
|
I have implemented these changes:
Let me know if anything else is needed! |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.






Closes #12243
This PR implements a follow-up questions feature to AI chat. After the AI responds to a user's question, the system automatically generates 3-5 relevant follow-up questions that appear as clickable links below the chat.
Changes:
FollowUpQuestionGeneratorclass to generate questions via AIAiChatLogicafter each AI responseSteps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)