-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Feature/related work annotator #14187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @jsochava!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
21d4bac to
711c3a9
Compare
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check your IDE config. It seems you refomatted too much with the wrong style. Hard to give content feedback.
|
@koppor when I used the IDE config described in the project's setup instructions, I consistently failed the automatic format checks. Is that expected? |
.idea/codeStyles/Project.xml
Outdated
| <option name="ENABLE_JAVADOC_FORMATTING" value="false" /> | ||
| <option name="JD_ALIGN_PARAM_COMMENTS" value="false" /> | ||
| <option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed this by accident... Please revert.
The configs changed. I don't know why. - See https://github.com/JabRef/jabref/pull/14187/files#r2535333190 |
|
@jsochava Please either install the browser plugin "refined github" to click on "Discard changes" on the 250+ files - or use some git magic to revert the change - force push is ok...
Don't forget to note down your commit id before the rewrite - in case something goes wrong, you can reset... Reason: We cannot let in 300+ files wrongly formatted. Reason: We are still humans changing the code and not fully AI. Example of bad reformats: |
Removing all accidentally changed files and only commiting related work files
f2fc2d1 to
d333a38
Compare
Closes #14085
This PR introduces a complete, deterministic pipeline for harvesting contextual summaries from a citing paper’s Related Work section, matching them to BibEntries, and optionally summarizing them using the new LangChain-based AI interface.
What and why
- SectionLocator → HeuristicRelatedWorkExtractor → RelatedWorkAnnotator
PdfTextProvider.java
-A tiny SPI interface: Path -> Optional plain-text extraction.
-Keeps all PDF specifics behind a seam; facilitates unit testing with fakes/mocks and avoids hard deps in core logic.
PdfRelatedWorkTextExtractor.java
- enableSummarization
- enableResolution
Next steps
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)