-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Migrate fetchers to Search.g4 ANTLR parser. #13691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
-Changed inherited fetcher classes to use ANTLR generated classes instead of lucene libraries. - Changed ACMPortalFetcher.java logic for transforming the parsed syntax to URL
jablib/src/main/java/org/jabref/logic/importer/fetcher/ACMPortalFetcher.java
Outdated
Show resolved
Hide resolved
Great start, to me it looks like your on the right track. |
- Changed ACMPortalFetcherTest unit test code to use Search.g4 generated classes instead of Lucene - Removed trivial comment from ACMPortalFetcher
- Changed AbstractQueryTransformer methods to obey Search.g4 parser rules - Modified ACMPortalFetcher to use the changed transformer logic
} | ||
|
||
/** | ||
* Constructing the url for the searchpage. | ||
* | ||
* @param query query node | ||
* @param queryList list that contains the parsed nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc comment merely restates what is obvious from the parameter name and type. It should provide additional information about the expected format or constraints of the query list.
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
Closes #13607
TO DO:
Steps to test
Using the Search.g4 syntax for searching on the web with different options.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)