-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add more walkthroughs, donation prompt, and responsive layout for welcome tab #13679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jabgui/src/main/java/org/jabref/gui/walkthrough/declarative/NodeResolver.java
Outdated
Show resolved
Hide resolved
if (preferences.getDonationPreferences().isNeverShowAgain()) { | ||
return; | ||
} | ||
int lastShown = preferences.getDonationPreferences().getLastShownEpochDay(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move the calculation to its own method with passing the preferences values as parameter, this allows you to create a simple test for it to verify the calculation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the calculateDaysUntilNextPopup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to push @Yubo-Cao
jabgui/src/main/java/org/jabref/gui/welcome/components/DonationProvider.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick review, need to look more in detail
jabgui/src/main/java/org/jabref/gui/walkthrough/declarative/NodeResolver.java
Outdated
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/walkthrough/declarative/NodeResolver.java
Show resolved
Hide resolved
@Yubo-Cao Once you address comments, before marking them as resolved, a good way to check if you have forgotten to push changes is to see if the review window is marked "Outdated". |
Hi Subhramit! I'm sorry for the confusion. I was applying all the changes locally, but then I realized IntelliJ automatically closes the changes when I use the suggested changes. |
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
scrollPane.setHbarPolicy(ScrollPane.ScrollBarPolicy.NEVER); | ||
scrollPane.setVbarPolicy(ScrollPane.ScrollBarPolicy.AS_NEEDED); | ||
scrollPane.getStyleClass().add("welcome-columns-scroll"); | ||
scrollPane.setStyle("-fx-background-color: transparent;"); // Using class selector is insufficient to prevent background from turning white on click. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment restates what is obvious from the code and doesn't provide additional value or reasoning behind the implementation decision.
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
Hey, no issues. Update: Check #13679 (comment) as well. |
Closes #12664
This PR introduces walkthroughs for add group and search in the library, responsive layout for welcome tab (to make sure the community links footer is always visible), and a donation popup to be shown 7 days after first launch, every 365 days.
Steps to test
Resize the window to show responsive layout
Click on the walkthroughs buttons to try them out
Try out donation popup is rather challenging. Modify the code to add a button in the
WelcomeTab
is one possible way to perform this, as shown below:Or alternatively, if you are using Windows,
Win+R
and type inregedit
to open the registry editor. Change the value ofHKEY_CURRENT_USER\Software\JavaSoft\Prefs\org\jabref\donation/Last/Shown/Epoch/Day
to0
will trigger donation prompt to be shown upon launch.You can find those feature demos here:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)