Show DOI lookup link in citation relations tab #13285
Open
+69
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the failing tests and follow the correct format for the PR description and title (check other prs for reference) |
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
Show resolved
Hide resolved
|
You can check the details of why a test is failing by clicking on it: And then go to the Files Changed tab to correlate it with your changes |
calixtus
reviewed
Jun 9, 2025
CHANGELOG.md
Outdated
| @@ -1575,6 +1576,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - We added the ability to use negation in export filter layouts. [#5138](https://github.com/JabRef/jabref/pull/5138) | |||
| - Focus on Name Area instead of 'OK' button whenever user presses 'Add subgroup'. [#6307](https://github.com/JabRef/jabref/issues/6307) | |||
| - We changed the behavior of merging that the entry which has "smaller" bibkey will be selected. [#7395](https://github.com/JabRef/jabref/issues/7395) | |||
| - we added a new | |||
calixtus
changed the title
|
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
reviewed
Jun 11, 2025
| .onSuccess(doiIdentifier -> { | ||
| if (doiIdentifier.isPresent()) { | ||
| entry.setField(StandardField.DOI, doiIdentifier.get().asString()); | ||
| searchForRelations(entry, listView, abortButton, refreshButton, searchType, importButton, progress, shouldRefresh); |
There was a problem hiding this comment.
you are introducing a recursive cascade here with endless creation of UI elements.
This needs to be done differently.
Extract the background task. put the result in a property. update the view if the property is modified.
calixtus
reviewed
Jun 11, 2025
| @@ -434,13 +444,29 @@ protected void bindToEntry(BibEntry entry) { | |||
| */ | |||
| private void searchForRelations(BibEntry entry, CheckListView<CitationRelationItem> listView, Button abortButton, | |||
| Button refreshButton, CitationFetcher.SearchType searchType, Button importButton, | |||
| ProgressIndicator progress) { | |||
| ProgressIndicator progress, boolean shouldRefresh) { | |||
There was a problem hiding this comment.
avoid magic booleans. if someone calls searchForRelations(...,...,true), nobody knows what true means. this may be done for simple methods, but for a recursive method self-documenting code is most important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13234
This PR enhances the "Citation relations" feature by making the "Look up a DOI and try again." text a clickable hyperlink. On clicking, the text changes to "Looking up DOI...". Based on the lookup result:
If a DOI is found, it is used for citation relations.
If no DOI is found, a notification "No DOI found" is shown and the link resets to its original state.
Steps to test
Add a paper in jabRef entry editor.
Go to citation relations. You will see hyperlink. Click on that hyperlink.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)