Skip to content

Remove usage of Injector in StyleSelectDialogViewModel #12983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

subhramit
Copy link
Member

@subhramit subhramit commented Apr 21, 2025

Follow-up to #12951.

Use BibEntryTypesManager from constructor instead of redundantly using injector in StyleSelectDialogViewModel.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Signed-off-by: subhramit <subhramit.bb@live.in>
@subhramit subhramit added the automerge PR is tagged with that label will be merged if workflows are green label Apr 21, 2025
Copy link

trag-bot bot commented Apr 21, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit subhramit added dev: code-quality Issues related to code or architecture decisions and removed automerge PR is tagged with that label will be merged if workflows are green labels Apr 21, 2025
@subhramit subhramit added this pull request to the merge queue Apr 21, 2025
Merged via the queue into JabRef:main with commit 3bccf1b Apr 21, 2025
1 check passed
@subhramit subhramit deleted the csl-cleanup-1 branch April 21, 2025 20:01
luks-santos pushed a commit to luks-santos/jabref that referenced this pull request Apr 22, 2025
Signed-off-by: subhramit <subhramit.bb@live.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants