[OO/CSL] Instantaneous citation insertion and refresh #12849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @@ -598,6 +598,10 @@ public void guiActionInsertEntry(List<BibEntry> entries, | |||
| if (style instanceof CitationStyle citationStyle) { | |||
| // Handle insertion of CSL Style citations | |||
|
|
|||
| // Lock document controllers - disable refresh during the process (avoids document flicker during writing) | |||
| // MUST always be paired with an unlockControllers() call | |||
| doc.lockControllers(); | |||
There was a problem hiding this comment.
The lockControllers() and unlockControllers() calls should be wrapped in a try-finally block to ensure that unlockControllers() is always called, even if an exception occurs.
| @@ -609,6 +613,9 @@ public void guiActionInsertEntry(List<BibEntry> entries, | |||
| cslCitationOOAdapter.insertEmptyCitation(cursor.get(), citationStyle, entries); | |||
| } | |||
|
|
|||
| // Release controller lock | |||
| doc.unlockControllers(); | |||
There was a problem hiding this comment.
The unlockControllers() call should be in a finally block to ensure it is executed even if an exception is thrown, maintaining the document's state integrity.
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted and superseded by #12851
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)