Skip to content

Tiny CSL architectural cleanup #12834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

subhramit
Copy link
Member

@subhramit subhramit commented Mar 26, 2025

Some quick architectural cleanups triggered by discussion at #12784 (comment).

  • Free CSLCitationOOAdapter completely of preferences.
  • Some related comments explaining usage of the initial style of generic style type to detect changes in styles in the adapter
  • Only one instance of CSLUpdateBibliography needed - some more breathing space for the garbage collector.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
@jabref-machine

This comment was marked as off-topic.

@subhramit subhramit changed the title Csl architectural cleanup Tiny CSL architectural cleanup Mar 26, 2025
@calixtus calixtus added this pull request to the merge queue Mar 27, 2025
Merged via the queue into JabRef:main with commit 4a0cba4 Mar 27, 2025
1 check passed
@calixtus calixtus deleted the csl-architectural-cleanup branch March 27, 2025 06:58
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* Remove dependency of preferences in adapter

Signed-off-by: subhramit <subhramit.bb@live.in>

* Use only one instance of `CSLUpdateBibliography`

Signed-off-by: subhramit <subhramit.bb@live.in>

---------

Signed-off-by: subhramit <subhramit.bb@live.in>
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* Remove dependency of preferences in adapter

Signed-off-by: subhramit <subhramit.bb@live.in>

* Use only one instance of `CSLUpdateBibliography`

Signed-off-by: subhramit <subhramit.bb@live.in>

---------

Signed-off-by: subhramit <subhramit.bb@live.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants