-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Update Java JDK from 21 to 22 #12134
Conversation
@@ -37,7 +37,7 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, windows-latest, macos-latest, buildjet-8vcpu-ubuntu-2204-arm] | |||
jdk: [22] | |||
jdk: [23] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't EA become 24 then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not supported by the current workflow. I can re-add this, but takes 30 to 60 min again - need to switch to Oracle action etc.
|
Blocked by beryx/badass-jlink-plugin#275. I don't want to use a patched version of the |
Since I also improved the links for updating and we should try if all dependencies work with a JDK "close enough" to JDK23, I "downgraded" to JDK 22 in this "upgrade" |
JDK 22 does not make sense, it's obsolete with the release of 23. |
Ah, yeah, I totally forgot. Now, I just have the documentation updates in - and some small version adaptions. |
.github/workflows/tests.yml
Outdated
@@ -309,7 +309,7 @@ jobs: | |||
if: github.ref == 'refs/heads/main' | |||
uses: actions/setup-java@v4 | |||
with: | |||
java-version: 22.0.2 | |||
java-version: 21.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21.0.5 ?
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/669
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)