Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Update Java JDK from 21 to 22 #12134

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Prepare Update Java JDK from 21 to 22 #12134

merged 11 commits into from
Oct 30, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 30, 2024

Refs https://github.com/JabRef/jabref-issue-melting-pot/issues/669

image

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@@ -37,7 +37,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest, buildjet-8vcpu-ubuntu-2204-arm]
jdk: [22]
jdk: [23]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't EA become 24 then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported by the current workflow. I can re-add this, but takes 30 to 60 min again - need to switch to Oracle action etc.

Siedlerchr
Siedlerchr previously approved these changes Oct 30, 2024
@Siedlerchr
Copy link
Member

Unsupported class file major version 67

@koppor
Copy link
Member Author

koppor commented Oct 30, 2024

Blocked by beryx/badass-jlink-plugin#275.

I don't want to use a patched version of the jlink plugin. Thus, I close this PR.

@koppor koppor closed this Oct 30, 2024
@koppor koppor reopened this Oct 30, 2024
@koppor koppor changed the title Update Java JDK from 21 to 23 Update Java JDK from 21 to 22 Oct 30, 2024
@koppor
Copy link
Member Author

koppor commented Oct 30, 2024

Since I also improved the links for updating and we should try if all dependencies work with a JDK "close enough" to JDK23, I "downgraded" to JDK 22 in this "upgrade"

@Siedlerchr
Copy link
Member

JDK 22 does not make sense, it's obsolete with the release of 23.

@koppor koppor changed the title Update Java JDK from 21 to 22 Preare Update Java JDK from 21 to 22 Oct 30, 2024
@koppor
Copy link
Member Author

koppor commented Oct 30, 2024

JDK 22 does not make sense, it's obsolete with the release of 23.

Ah, yeah, I totally forgot.

Now, I just have the documentation updates in - and some small version adaptions.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 30, 2024
@@ -309,7 +309,7 @@ jobs:
if: github.ref == 'refs/heads/main'
uses: actions/setup-java@v4
with:
java-version: 22.0.2
java-version: 21.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21.0.5 ?

Copy link
Contributor

github-actions bot commented Oct 30, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 9d9a251 Oct 30, 2024
29 of 33 checks passed
@calixtus calixtus deleted the update-java-to-jdk23 branch October 30, 2024 22:45
@ThiloteE ThiloteE changed the title Preare Update Java JDK from 21 to 22 Prepare Update Java JDK from 21 to 22 Oct 30, 2024
@koppor koppor mentioned this pull request Nov 9, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants