Remove updateEntryEditorIfShowing #12129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
updateEntryEditorIfShowing
seems to be a left-over of old times.It was called very rarely.
Since the argument for
showAndEdit
was the currently entry, the only action the thing did was to focus the entry editor. The callers were "Cleanup" and "SpecialFieldAction". I don't think, they need an entry editor focus.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)