Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove updateEntryEditorIfShowing #12129

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 30, 2024

The method updateEntryEditorIfShowing seems to be a left-over of old times.

It was called very rarely.

Since the argument for showAndEdit was the currently entry, the only action the thing did was to focus the entry editor. The callers were "Cleanup" and "SpecialFieldAction". I don't think, they need an entry editor focus.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 30, 2024
@calixtus
Copy link
Member

Changelog needed?

@koppor
Copy link
Member Author

koppor commented Oct 30, 2024

Changelog needed?

I don't think so. Would be too cryptic IMHO.

@koppor koppor added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 53d0929 Oct 30, 2024
27 checks passed
@koppor koppor deleted the remove-udpate-entry-editor-if-showing branch October 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants