Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always select entry in main table when showing entry editor #12128

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 30, 2024

In some code patghways, the entry editor was shown, but the main table selection was not updated.

IMHO if the entry editor is shown - there should be a single (!) entry in the main table focused: The entry currently edited.

(This PR contains some code cleanup from #12124 - the important change is the removal of explicit clearAndSelect calls and include them into showAndEdit)

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 109c2b1 Oct 30, 2024
26 checks passed
@koppor koppor deleted the entry-editor-consistency branch October 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants