Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to stream-based loading #11479

Merged
merged 16 commits into from
Jul 17, 2024
Merged

Switch to stream-based loading #11479

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2655432
Switch to stream-based loading
koppor Jul 10, 2024
157a448
Fix typos
koppor Jul 10, 2024
cad404c
Add architecture test
calixtus Jul 11, 2024
5dbc4a3
Fix ProtectedTermsLoaderTest and minor refactor
calixtus Jul 11, 2024
11c1be7
Remove "static"
koppor Jul 11, 2024
aa8f549
Introduce AllowedToUseClassGetResource - and do some rewrite
koppor Jul 11, 2024
ba104cb
Streamline FileUtil.copy
koppor Jul 11, 2024
c140774
Rewrite CitationStyle.java more to streams
koppor Jul 11, 2024
66d2d64
More change to asStream
koppor Jul 11, 2024
338f7b0
Convert to getResourceAsStream
koppor Jul 11, 2024
17aa7c0
Remoe unused imports
koppor Jul 11, 2024
acee78e
Merge branch 'main' into switch-to-stream
koppor Jul 11, 2024
4e3a407
Fix MathMLParser
calixtus Jul 11, 2024
599b980
Remove imports
koppor Jul 12, 2024
f36dfa3
Fix test
koppor Jul 12, 2024
0f068f3
Merge branch 'main' into switch-to-stream
koppor Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/jabref/logic/importer/util/MathMLParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@
import javax.xml.transform.stream.StreamResult;
import javax.xml.transform.stream.StreamSource;

import org.jabref.architecture.AllowedToUseClassGetResource;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@AllowedToUseClassGetResource("to determine the root directory")
public class MathMLParser {
private static final Logger LOGGER = LoggerFactory.getLogger(MathMLParser.class);
private static final String XSLT_FILE_PATH = "/xslt/mathml_latex/mmltex.xsl";
Expand All @@ -38,7 +41,7 @@ public static String parse(XMLStreamReader reader) {
Source xmlSource = new StreamSource(new StringReader(xmlContent));

// No SystemId required, because no relative URLs need to be resolved
Source xsltSource = new StreamSource(xsltResource);
Source xsltSource = new StreamSource(xsltResource, MathMLParser.class.getResource(XSLT_FILE_PATH).toExternalForm());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for a workaround. - Can we do add a fake path here? Maybe, #future work


TransformerFactory transformerFactory = TransformerFactory.newInstance();
Transformer transformer = transformerFactory.newTransformer(xsltSource);
Expand Down
Loading