Update search results when active database changes

[LoayGhreeb]

Closes #11267

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[calixtus]

I think this won't work. Now you update when changing the database, but not if the search query itself is altered.
Maybe a new string binding with multiple observables will work here.

[LoayGhreeb]

I think this won't work. Now you update when changing the database, but not if the search query itself is altered.

the search query has a listener too.

jabref/src/main/java/org/jabref/gui/search/GlobalSearchBar.java

Line 240 in 3abdefd

this.searchQueryProperty.addListener((obs, oldValue, newValue) -> newValue.ifPresent(this::updateSearchResultsForQuery));

[Siedlerchr]

Thanks for the quick fix

[calixtus]

so this line was just duplicated?

[LoayGhreeb]

so this line was just duplicated?

yes, I accidentally did this in #11032.

- this.stateManager.activeDatabaseProperty().addListener((obs, oldValue, newValue) -> stateManager.activeSearchQueryProperty().get().ifPresent(this::updateSearchResultsForQuery));

+ this.searchQueryProperty.addListener((obs, oldValue, newValue) -> searchQueryProperty.get().ifPresent(this::updateSearchResultsForQuery));

[calixtus]

Ah ok. Forgiven and forgotten. 😄