Skip to content

Introduce BibliographyConsistencyCheckResultTxtWriter #10847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 9, 2024
Merged

Introduce BibliographyConsistencyCheckResultTxtWriter #10847

merged 15 commits into from
Feb 9, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 2, 2024

Follow-up to #10778

  • Introduces BibliographyConsistencyCheckResultTxtWriter (as preparation of a CI action)
  • Renames PaperConsistencyCheck to BibliographyConsistencyCheck, because that is more correct.
  • Regroup some contents of JabRef_en.properties

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor added 15 commits January 14, 2024 20:34
@koppor
Adds check of consistency of given entries by looking at the present …
c79e252 
…and absent fields.
@koppor
Remove obsolete file
d7bbb77
@koppor
Refactoring
5819806
@koppor
Refactoring to enable more writers
6f65060
@koppor
WIP
6306180
@koppor
Merge branch 'main' into add-quality-check
2430500
@koppor
Use Writer instead of Path
a3a71fe
@koppor
Merge branch 'main' into add-quality-check
4d01a24
@koppor
Add legend to txt writer
a5e491c
@koppor
Finish ResultTxtWriter
03a87ed
@koppor
Merge branch 'add-quality-check' of github.com:koppor/jabref into add…
49ed734 
…-quality-check

# Conflicts:
#	src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheckResultTxtWriter.java
#	src/test/java/org/jabref/logic/quality/consistency/PaperConsistencyCheckResultTxtWriterTest.java
@koppor
Merge branch 'main' into add-quality-check
64405e4
@koppor
Fix OpenRewrite issue
09c3f83
@koppor
Fix tests
cf70e11
@koppor
Remove obsolete key "Legend"
cd50bff
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 5, 2024
calixtus
calixtus approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are somewhat weird, but seem to be ok.
So approved!

@koppor koppor added this pull request to the merge queue Feb 9, 2024
Merged via the queue into JabRef:main with commit 13870d8 Feb 9, 2024
@koppor koppor deleted the add-quality-check branch February 9, 2024 11:00
Siedlerchr added a commit to rdsingh13/jabref that referenced this pull request Feb 11, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-9803
4378e0d 
* upstream/main: (68 commits)
  BibTeX 'Title' to MS Office 'Publicationtitle' field (JabRef#10864)
  Introduce BibliographyConsistencyCheckResultTxtWriter (JabRef#10847)
  Upgrade gradle-build-action to actions/setup-gradle (JabRef#10866)
  Bump org.apache.lucene:lucene-core from 9.9.1 to 9.9.2 (JabRef#10860)
  Bump org.junit.jupiter:junit-jupiter from 5.10.1 to 5.10.2 (JabRef#10863)
  Bump org.apache.lucene:lucene-highlighter from 9.9.1 to 9.9.2 (JabRef#10861)
  Bump org.tinylog:tinylog-api from 2.6.2 to 2.7.0 (JabRef#10862)
  Bump org.apache.lucene:lucene-queryparser from 9.9.1 to 9.9.2 (JabRef#10859)
  Bump gradle/wrapper-validation-action from 1 to 2 (JabRef#10858)
  Bump codecov/codecov-action from 3 to 4 (JabRef#10857)
  Bump peter-evans/create-pull-request from 5 to 6 (JabRef#10856)
  Update Gradle Wrapper from 8.5 to 8.6. (JabRef#10854)
  Enable auto merge of gradle wrapper update
  Jump to entry from cli (JabRef#10578)
  Fix closing of JabRef in case of issues with index writer (JabRef#10840)
  Update deployment-arm64.yml
  use nio path
  fix submodules
  Fix secrents presence chcek
  Update deployment-arm64.yml
  ...
This was referenced Oct 13, 2024
Closed
Closed
tsantalis added a commit to tsantalis/RefactoringMiner that referenced this pull request Jan 21, 2025
@tsantalis
Handle properly mappings with nested lambda mappers
3bdbf30 
JabRef/jabref#10847
Extract And Move Method	protected getFindingsAsList(bibEntry BibEntry, entryType String, requiredFields Set<Field>, optionalFields Set<Field>) : List<String> extracted from protected writeBibEntry(bibEntry BibEntry, entryType String, requiredFields Set<Field>, optionalFields Set<Field>) : void in class org.jabref.logic.quality.consistency.PaperConsistencyCheckResultCsvWriter & moved to class org.jabref.logic.quality.consistency.BibliographyConsistencyCheckResultWriter
tsantalis added a commit to tsantalis/RefactoringMiner that referenced this pull request Jan 31, 2025
@tsantalis
Enable detection of overlapping Extract Attribute refactoring in
7511921 
JabRef/jabref#10847
PaperConsistencyCheckResultCsvWriter.java ⇨ BibliographyConsistencyCheckResultWriter.java
The refactoring takes place on top of Extract and Move Method refactoring
victorgveloso pushed a commit to victorgveloso/RefactoringMiner that referenced this pull request Feb 19, 2025
@tsantalis @victorgveloso
Enable detection of overlapping Extract Attribute refactoring in
8bcab7b 
JabRef/jabref#10847
PaperConsistencyCheckResultCsvWriter.java ⇨ BibliographyConsistencyCheckResultWriter.java
The refactoring takes place on top of Extract and Move Method refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @calixtus