Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cache: gradle with "modern" gradle-build-action #10657

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Replace cache: gradle with "modern" gradle-build-action #10657

merged 2 commits into from
Nov 22, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 21, 2023

Reasons at https://github.com/gradle/gradle-build-action#why-use-the-gradle-build-action

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor changed the title Replace cache: gradle with "odern" gradle-build-action Replace cache: gradle with "modern" gradle-build-action Nov 21, 2023
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 0b0fcc9 Nov 22, 2023
18 of 19 checks passed
@koppor koppor deleted the switch-to-gradle-build-action branch November 22, 2023 10:23
yuyan-z pushed a commit to yuyan-z/jabref that referenced this pull request Nov 25, 2023
@koppor @yuyan-z
Replace cache: gradle with "odern" gradle-build-action (JabRef#10657)
5a5b611
Siedlerchr added a commit that referenced this pull request Nov 26, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-10424
b9b4da0 
* upstream/main:
  App semantic scholar api key to properties (#10656)
  Replace cache: gradle with "odern" gradle-build-action (#10657)
  Clean up test code (#10658)
  Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (#10650)
  Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (#10654)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#10653)
  Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8
  Remove comments - don't work on forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr