Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments - don't work on forks #10649

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove comments - don't work on forks #10649

merged 1 commit into from
Nov 20, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 20, 2023

I thought it would be nice to have some messages at PRs when sth goes wrong.

However, only persons with access rights to this repo get these texts - others not.

Thus, I remove them.

@reviewdog can. Follow-up is to convert the output in case of errors to a format consumable to reviewdog.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr merged commit 3956934 into main Nov 20, 2023
17 of 18 checks passed
@Siedlerchr Siedlerchr deleted the remove-commenting branch November 20, 2023 14:57
Copy link
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants