RIS import takes the wrong date and duplicates abstract

[crystalfp]

JabRef 4.3.1
Windows 10 10.0 amd64
Java 1.8.0_172

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem (partially) persists

Publication date taken from the wrong field and the abstract is the concatenation of two fields importing a RIS file.

Steps to reproduce the behavior:

1. Import the following RIS file (from the Neurons journal):

TY  - JOUR
T1  - Grid Cells for Conceptual Spaces?
AU  - Kriegeskorte, Nikolaus
AU  - Storrs, Katherine R.
Y1  - 2016/10/19
PY  - 2016
N1  - doi: 10.1016/j.neuron.2016.10.006
DO  - 10.1016/j.neuron.2016.10.006
T2  - Neuron
JF  - Neuron
SP  - 280
EP  - 284
VL  - 92
IS  - 2
PB  - Elsevier
N2  - ?Grid cells? encode an animal?s location and direction of movement in 2D physical environments via regularly repeating receptive fields. Constantinescu et al. (2016) report the first evidence of grid cells for 2D conceptual spaces. The work has exciting implications for mental representation and shows how detailed neural-coding hypotheses can be tested with bulk population-activity measures.
AB  - ?Grid cells? encode an animal?s location and direction of movement in 2D physical environments via regularly repeating receptive fields. Constantinescu et al. (2016) report the first evidence of grid cells for 2D conceptual spaces. The work has exciting implications for mental representation and shows how detailed neural-coding hypotheses can be tested with bulk population-activity measures.
SN  - 0896-6273
M3  - doi: 10.1016/j.neuron.2016.10.006
UR  - https://doi.org/10.1016/j.neuron.2016.10.006
Y2  - 2020/03/04
ER  - 

2. The publication date is taken from the Y2 field, not from the correct Y1 field. This has been fixed in 5.0 portable.
3. The abstract field is the concatenation of the AB and N2 fields.

Log File

Paste an excerpt of your log file here

[sksonalkothari]

Hi, I would like to contribute to this issue, I am new in open source development.

[Siedlerchr]

@sksonalkothari Thanks for your interest and welcome to JabRef!
Please read through the Contribution Guidelines and set up a workspace

For this issue the relevant code is located in the file: src/main/java/rg/jabref/logic/importer/fileformat/RisImporter.java

[sksonalkothari]

Hi @Siedlerchr, I did as given in guidelines-for-setting-up-a-local-workspace. And I could successfully run the application. But I could not debug through Eclipse. Its giving me error. I even checked the Gitter group chat for this issue, It seems many people had this one.
But yaa, I went and checked the file which u suggested src/main/java/rg/jabref/logic/importer/fileformat/RisImporter.java
Code seems good, it has a dateTags list, which stores all the date tags from highest to lowest priority ("Y1", "PY", "DA", "Y2"). So if we have some date with Y1, it will be seen on the UI. And I confirmed this on UI. We get the Y1 date.

For the other concern related to Abstract field, code says that abstract is the concatenation of two fields (N2+AB).
else if ("N2".equals(tag) || "AB".equals(tag)) { String oldAb = fields.get(StandardField.ABSTRACT); if (oldAb == null) { fields.put(StandardField.ABSTRACT, value); } else { fields.put(StandardField.ABSTRACT, oldAb + OS.NEWLINE + value); } }
I didn't get the requirement, what needs to be done here.

[Siedlerchr]

@sksonalkothari Sorry for the delay. It seems the abstract should only be taken from either the field
AB or the fields N2 instead of concatenation.
So if, AB is empty, take N2

[tobiasdiez]

Thanks to @Gena928 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[crystalfp]

The abstract problem seems solved.

But

In the new version the biblatex library indicator disappeared and I remember was easier in the 4.x version to set this mode. Should I open another issue for this?

Thanks for your work!
mario

[Siedlerchr]

@crystalfp That can be changed in Library Properties