Bibtex key generator bug introduced

[wujastyk]

JabRef version
JabRef 5.0-dev--snapshot--2019-03-16--master--d7dd41b00
Linux 4.15.0-46-generic amd64
Java 1.8.0_201

on Linux Mint 19.1

• I have tested the latest development version from http://builds.jabref.org/master/ and the problem persists

Steps to reproduce the behavior:

1. open Options/Preferences/BibTeX key generator
2. set the key to "[auth4:lower]-[year]"
3. In the entry editor, using ctrl+G to create the key produces output without the hyphen. E.g., "smit2019" instead of the expected "smit-2019".

It worked fine in JabRef 5.0 dev until recently, and it works in older version of JR.

Log File

Opening: /home/dom/Dropbox/localtexmf/bibtex/bib/biblio4-utf8.bib
Opening: /tmp/jabref1689428551091217694.bib
Opening: /tmp/jabref1689428551091217694.bib
Opening: /home/dom/Dropbox/localtexmf/bibtex/bib/biblio4-utf8.bib
Opening: /home/dom/Dropbox/localtexmf/bibtex/bib/biblio4-utf8.bib

[Siedlerchr]

Maybe a side effect from #4709?

[tim-kilian]

This is because - is an illegal character in the BibtexKeyGenerator KEY_ILLEGAL_CHARACTERS pattern.

jabref/src/main/java/org/jabref/logic/bibtexkeypattern/BibtexKeyGenerator.java

Line 29 in d7dd41b

private static final String KEY_ILLEGAL_CHARACTERS = "{}(),\\\"-#~^':`";

I think, that the problem is, that this pattern is used to prevent illegal characters inside the fields, but also it clears the wanted characters at the end of building process.