Scrollbar invisible in Preferences -> BibTex Key Pattern

[Siedlerchr]

@tobiasdiez

And you should set the colspan of the gridpane which includes the pane of the biblatex key panel to 2

[Siedlerchr]

Edit// I think we need to add css properties for the scroll pane, e.g.scroll-pane > .corner
Description of the CSS properties: https://blog.ngopal.com.np/2012/07/11/customize-scrollbar-via-css/

[omkarnix]

As a first timer, can I pick this issue if nobody is working on it?

[Siedlerchr]

@omkarnix Sure, go ahead!

[omkarnix]

Sure. I am working on it. Thanks for the encouragement!

[omkarnix]

@Siedlerchr Sorry for late response. I tried to fix this by following the given tutorial but looks like need some more time to learn Java FX its CSS, scrollbar. But I think I will be able to contribute better at back-end side in fixing issues or writing tests. Will search for issues and see if I can help there.
Also, please let me know if you think there is any back-end or devops issue in which I could contribute.
Thanks!

[omkarnix]

@Siedlerchr
Also, can we use some open source tool like SonarCube to find code coverage and start adding the tests suggested by the tool?

[Siedlerchr]

@omkarnix Well, just look at the list of open issues. While many of them are related to the GUI transformation from swing to JavaFx, there are also some non GUI issues.
One important issue is the check for multipe instances of JabRf: #4023

We have code coverage reports enabled here as well, but the statistics are irrelevant as the most important things are already covered (e.g. logic and model) .

[tobiasdiez]

@omkarnix most of the issues tagged with code quality, fetcher or import/export are mostly concerned with the backend:
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Acode-quality
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Afetcher
https://github.com/JabRef/jabref/issues?q=is%3Aissue+is%3Aopen+label%3Aimport
https://github.com/JabRef/jabref/labels/export%20%2F%20save

Tests are important as well, especially for the model/logic as @Siedlerchr said. Feel free to add tests for uncovered parts, but please don't write test methods for trivial code (such as getter & setter).

[omkarnix]

@tobiasdiez Sure. Thanks. I would certainly like to contribute on tests.