Gradle task localizationUpdate does not work

[tobiasdiez]

localizationUpdate leads to resorting and adding of many language keys due to the recent changes. Thus, at the moment it is not possible to remove a pair from the english file and propagate this change to the other languages.

[koppor]

I think, I can work on that in January. Meanwhile, you should be able to log in at crowdin and remove the key there. Need to make you maintainer there, though.

[koppor]

Please DO NOT remove obsolete keys in other language files. This is done by crowdin automatically: #3585

I will remove the task completely or have it output that there is no need for a check, because of crowdin!

[tobiasdiez]

@koppor Right now we have tests in place that require to remove obsolete language keys from other languages. It would be nice if we could remove the localizationUpdate step completely (less things to do manually), but then the tests should be adopted accordingly.

[koppor]

I thought, I adapted the tests. Seems, I missed something. Have to check... Am 05.01.2018 12:01 schrieb "Tobias Diez" <notifications@github.com>:

…

@koppor <https://github.com/koppor> Right now we have tests in place that require to remove obsolete language keys from other languages. It would be nice if we could remove the localizationUpdate step completely (less things to do manually), but then the tests should be adopted accordingly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3573 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTaftbvUCzp6PiQbYoCZPnhgV_ph9zcks5tHgECgaJpZM4RLq3L> .

[tobiasdiez]

This test fails if you remove language keys from the english file but not from the others:

jabref/src/test/java/org/jabref/logic/l10n/LocalizationConsistencyTest.java

Lines 50 to 51 in 3b2d35f

	@Test
	public void nonEnglishFilesMustHaveSubsetOfKeys() {

(If crowdin handles this case automatically, then there is no need for this test, right?)

A few other tests still refer to the localizationUpdate (which should not be invoked, right?), e.g.,

jabref/src/test/java/org/jabref/logic/l10n/LocalizationConsistencyTest.java

Lines 140 to 142 in 3b2d35f

	assertEquals("DETECTED LANGUAGE KEYS WHICH ARE NOT IN THE ENGLISH LANGUAGE FILE\n" +
	"1. PASTE THESE INTO THE ENGLISH LANGUAGE FILE\n" +
	"2. EXECUTE: gradlew localizationUpdate\n" +

[koppor]

It is not as straight-forward as I thought.

English escapes more characters than non-English:

Executing\ command\ \"%0\"...=Executing command \"%0\"...

German:

Executing\ command\ "%0"...=Ausführung des Kommandos "%0"...

[Siedlerchr]

Any updates on this? I think we don't need the script anylonger or?