Refine check at LinkedFileHandler#getSuggestedFileName(java.lang.String)

[koppor]

The if condition at org.jabref.logic.externalfiles.LinkedFileHandler#getSuggestedFileName(java.lang.String) checks for -. The reason is that [bibtexkey] - [title] is the default pattern (see org.jabref.logic.FilePreferences#DEFAULT_FILENAME_PATTERNS).

The return of

Task:

1. The return type of org.jabref.logic.util.io.FileUtil#createFileNameFromPattern should be Optional. If the empty string (or "-" or "default") would be returned, return an empty optinal. Note that test cases need to be adapted. Especially instead of "default", there will be Optional.empty().
2. Adapt org.jabref.logic.util.io.FileUtil#createFileNameFromPattern to return an empty Optional if no brackets could be replaced.

Hint:

• ´org.jabref.logic.citationkeypattern.BracketedPattern#expandBrackets(java.lang.String, java.util.function.Function<java.lang.String,java.lang.String>)can be used with a function returning "" for each input string. Then, one retrieves all non-bracktet characters from the input stirng. Example:[AUTHOR] - [YEAR]will result in - `.
• Add with a JUnit test for expandBrackets to ensure the claim is current.
• If the claim is correct, task 2 should be "easy" to do by "just" calling expandBrackets with the empty string function and checking if targetName equals that name.

---

Background: Risen by #13295.

[github-actions]

👋 Hey @bhumijain19, looks like you’re eager to work on this issue — great! 🎉 It also looks like you don't know how to assign issues to yourself. Please read our CONTRIBUTING.md to find out how. It will also guide you in other aspects of contributing to JabRef.

[alexanderbodnar]

/assign-me

[github-actions]

👋 Hey @alexanderbodnar, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

For questions on JabRef functionality and the code base, you can consult the JabRef Guru or ask on our Gitter chat.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[github-actions]

⏰ Assignment Reminder

Hi @alexanderbodnar, this is a friendly reminder about your assignment to this issue.

Warning

This issue will be automatically unassigned in 11 days if there's no activity.

Remember that you can ask the JabRef Guru or DeepWiki about anything regarding JabRef.
Additionally, our contributing guide has hints on creating a pull request and a link to our Gitter chat.

How to keep your assignment

If you are working on it, you can prevent automatic unassignment by:

• Submitting a draft pull request with your progress within 11 days
• Asking for the 📌 Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

[Siedlerchr]

@jetbrains-junie Follow the implementation hints in the issue description

[jetbrains-junie]

Hey, it’s Junie by JetBrains! I started processing your request 🚀

[jetbrains-junie]

❌ Application Setup Failed

We couldn't start the application due to an environment issue during setup.

Error Details:

Dev container build failed: Command failed: docker buildx build --load --build-context dev_containers_feature_content_source=/tmp/devcontainercli-runner/container-features/0.80.1-1757018641229 --build-arg _DEV_CONTAINERS_BASE_IMAGE=mcr.microsoft.com/devcontainers/base:debian --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp --target dev_containers_target_stage -f /tmp/devcontainercli-runner/container-features/0.80.1-1757018641229/Dockerfile.extended -t undefined:latest /tmp/devcontainercli-runner/empty-folder (exit code: undefined)
Command failed: docker buildx build --load --build-context dev_containers_feature_content_source=/tmp/devcontainercli-runner/container-features/0.80.1-1757018641229 --build-arg _DEV_CONTAINERS_BASE_IMAGE=mcr.microsoft.com/devcontainers/base:debian --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp --target dev_containers_target_stage -f /tmp/devcontainercli-runner/container-features/0.80.1-1757018641229/Dockerfile.extended -t undefined:latest /tmp/devcontainercli-runner/empty-folder

More information:

• 🔗 GitHub Action
• 📘 Devcontainer documentation
• 💬 Report the issue on our Discord and help us improve