Fix MappedBackedList
when the change is wasUpdated
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue related to
EasyBind#mapBacked
. The problem arises when using aSortedList
with elements that are mapped usingEasyBind#mapBacked
. The updates to elements in the list do not propagate to theSortedList
.Minimal Example:
Output:
Expected Output:
The issue is due to using
nextUpdate
after changing the object. CallingnextUpdate
, the listeners expect that changes are made to the object's properties, not to the object itself. If the object itself changes,nextSet
should be called instead.From the
FXCollections#observableArrayList(Callback<E, Observable[]>)
documentation:mapOnUpdate
option tomapBacked
: creating a new object on update may not always be needed, especially if the object has bindings that already reflect changes in the mapped object.