Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hyprland.sh #142

Closed
wants to merge 11 commits into from
Closed

Refactor Hyprland.sh #142

wants to merge 11 commits into from

Conversation

brrock
Copy link

@brrock brrock commented Aug 14, 2024

Refactor Hyprland.sh

Description

This checks if the OS is a Ubuntu or Debain by reading the OS release file and then install hyprland and a dependence using the way the project normally uses, if the OS it is Ubuntu and same for Ubuntu like distros, the script enables the universe repos required by hyprland and runs sudo apt update.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Debian-Hyprland wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@JaKooLit
Copy link
Owner

its not good to read OS release else wont be used to distros which are based to either ubuntu or debian

atleast thats what I enountered.. thats why I didnt integrate that function and I have to separate the repo

@JaKooLit
Copy link
Owner

But anyway thanks

I think you accidentally uploades install-logs?

@brrock
Copy link
Author

brrock commented Aug 14, 2024

Oh sorry I was testing forgot to remove

@brrock
Copy link
Author

brrock commented Aug 14, 2024

Just updating now

@JaKooLit
Copy link
Owner

Instead of the OS name would the OS ID work

not sure

if I remember it correctly, Ive even got a message that he tested to another distro, which I didnt even know it exist.

thats why it is safer to not read any from OS releases..

they just need to figure out either based on ubuntu or debian

@brrock
Copy link
Author

brrock commented Aug 14, 2024

I'm testing on Zorin OS and ubuntu cause it is what is in my ventoy

@JaKooLit
Copy link
Owner

hmmm.. correct me if Im wrong...

but it seems on your PR, will add the universe repo even if its debian... should be only on ubuntu instead?

@brrock
Copy link
Author

brrock commented Aug 14, 2024

sorry the script is fine I just miss wrote the description sry and just edited

@brrock
Copy link
Author

brrock commented Aug 14, 2024

@JaKooLit

@brrock
Copy link
Author

brrock commented Aug 15, 2024

Some minor bug fixes

@brrock
Copy link
Author

brrock commented Aug 15, 2024

@JaKooLit

@JaKooLit
Copy link
Owner

pls, DO NOT keep pinging me....

I already mentioned that I am busy and only at the end of this month that I will be free.....

@brrock
Copy link
Author

brrock commented Aug 15, 2024

Sorry bro

@JaKooLit
Copy link
Owner

hey...

Managed to review this..

However, wont be merging... as there are lots of adjustments.....

I started already the process..

You will see the "changes" I am making

@JaKooLit JaKooLit closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants