Merged
Conversation
| elif arch in ('arm64', 'aarch64'): | ||
| arch = 'arm64' | ||
| else: | ||
| raise EnvironmentError(f"Unsupported architecture: {arch}") |
Contributor
Author
There was a problem hiding this comment.
Can fallback to x64 if you prefer
Owner
|
Thanks for the PR @ross-mcnairn-dev! Will take a look tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, this project is great! Thanks :).
I want to add support for ARM systems. I'm working with Docker containers on an M1, and while I can use the ISA emulator to build this on x86, it's so slow that it took me less time to make this PR than it did to install the package via pip.
I also adjusted the README with some minor changes based on what I encountered setting things up / running tests.
Hope this helps! Happy to adjust as you see fit.