Incorporate Changes from SpotDraft Fork #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typos
The code has been updated to include support for macOS in the build and extraction process of the project. A new section is added to perform build and compression for macOS, in addition to existing mechanisms for Windows and Linux. The extraction method in engines.py is also modified to handle macOS specific binaries.
|
Hi @JSv4, thanks for merging this. I originally planned to raise a PR once I tested the MacOS support. Also, it would be great if you could publish this on pypi.org. :) |
|
No problem @rishabh-sagar-20. Figured maybe you got busy :-). I am going to publish today. I had to tweak the packaging to get it to successfully publish. Will try again today. |
|
Thanks. I was actually working on a similar set of changes (not finished) in PR #6. I'll merge your changes in first, then I have some packaging improvements I think are necessary for the PyPi publication to work properly. |
|
Thanks @JSv4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotdraft kindly fixed a couple of typos in their fork and added MacOS support (which I can't test, sadly).