Skip to content

fix bug of TablesNamesFinder when SubSelect has withItemsList #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2016
Merged

fix bug of TablesNamesFinder when SubSelect has withItemsList #321

merged 1 commit into from
Aug 4, 2016

Conversation

iceflying
Copy link
Contributor

In original code, TablesNamesFinder just parse the selectBody in a SubSelect object. However it would lead to a mistake when a SubSelect object has withItemsList. This pull request fix it and add the corresponding unit test.
By the way, for the universal of unit test module, this pull request use Statement object replacing Select object.
Thanks for your reading.

@coveralls
Copy link

coveralls commented Aug 4, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 83.787% when pulling 276ddc8 on iceflying:tables_names_finder_oracle_bugs into 37f0610 on JSQLParser:master.

@wumpz wumpz merged commit 1b1655c into JSQLParser:master Aug 4, 2016
@iceflying iceflying deleted the tables_names_finder_oracle_bugs branch August 5, 2016 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iceflying @coveralls @wumpz