Skip to content

Unit tests support multi-os and higher versions of jdk #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2023
Merged

Unit tests support multi-os and higher versions of jdk #1886

merged 2 commits into from
Nov 8, 2023

Conversation

kslex
Copy link
Contributor

@kslex kslex commented Nov 8, 2023 •
edited
Loading

When I run unit tests, there are two failures:

  1. ParserKeywordsUtilsTest#getAllKeywords failed to run. Because my os is windows and the regex in ParserKeywordsUtils#getAllKeywordsUsingRegex seems not support multi-os.
  2. Compilation fails when using JDK 17. Nashorn has been deprecated after jdk11 and removed after jdk15.

@manticore-projects
Copy link
Contributor

Greetings!
Thank you for your contribution, especially the fix of the Regex is great.

@manticore-projects manticore-projects merged commit 97e9229 into JSQLParser:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kslex @manticore-projects