add support for postgres drop function statement #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greetings. Thank you very much for your contribution. It looks great, kudos! |
|
Since I'm new to open source development and contribution, I wanted to ask when and how often are the pull requests merged to master. |
Honestly, I do not know either and I am thinking about establishing a "Development Branch", which would merge any pending PRs under a rolling release model. |
|
@rrrship sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a support for PostgreSQL DROP FUNCTION statement: PostgreSQL DROP FUNCTION documentation
Also added a new map to Drop class to store parameters by type. Not sure about other drop types, but drop function actually has a more richer syntax with additional parameters which we could support in the future. Storing them in a map could possibly hold off bloating the class.