Merge 0-4-0 into master #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use filter query param for filtering
This change lets the user specify a model manager for the fluent config to use. This means that type registrations will be done directly against the model manager instead of the fluent config. This isn't the nicest solution, but without taking over the IDependencyResolver, I couldn't think of anything better.
Figured this made more sense as an extension method.
Before, returning null from an action would throw an exception. Now, it serializes null or an empty array, depending on the cardinality of the action result type.
This was causing null reference exceptions when materializing new objects of types that have to-many relationships.
I removed the obsolete methods as well as the non-generic versions. It was only complicating the implementation of EntityFrameworkMaterializer, and making it harder to override that class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think given the recent progress of the json-api specification and the imminent 1.0 launch, it doesn't really make sense for us to release a 0.3.0 version of JSONAPI.NET that targets a pre-RC2 version of the spec. IMO we should merge 0-4-0 and just go back to doing work on master until we are ready to make a json-api 1.0-compliant release.