require registration of resource types #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR paves the way for polymorphism (#73) and heterogeneous collection support by requiring the user to pre-register all resource types. This will be a major breaking change as existing apps will fail until they add their necessary registrations.
I changed the language of
GetJsonKeyForType
toGetResouceTypeNameForType
because the spec no longer wants primary data to be keyed by type, but rather by the worddata
. "Resource type name" seemed a more apt description of what we are determining.I also added a virtual method on
ModelManager
calledCalculateResourceTypeNameForType
which will allow sub-classes to override the default strategy for determining the resource type name.@SphtKr do you have any concerns?