docs: agree on the golden-AST and robustness counts across the docs - #175
Merged
Conversation
Co-Authored-By: jason.han <jason.han@jpl.nasa.gov>
Author
Original prompt from jason.han
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#174 added one golden AST fixture (
parse/behavior_first_then_declared_node) and threerobustness subtests, and updated the counts in
README.mdanddocs/SPEC_COMPLIANCE.mdonly — so
docs/ARCHITECTURE.md,docs/TESTING.md,docs/ROADMAP.mdand theimplementation-files table in
docs/SPEC_COMPLIANCE.mdstill said 80 fixtures / 143subtests, contradicting the same numbers a few lines away and the tree itself
(
ls internal/core/parser/testdata/parse/*.golden= 81).Docs-only: 80 → 81 golden ASTs, 143 → 146 robustness subtests, in the six places that
still carried the old values.
docs/RELEASING.mdrequires these to agree across the docsthat repeat them.
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/63a35983480640b28891656068676bd8
Requested by: @HuiJun