Drop support for older versions of gradle and ktlint #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
drop-gradle-6
branch
3 times, most recently
from
40620f0
to
31b19ce
Compare
wakingrufus
force-pushed
the
drop-gradle-6
branch
13 times, most recently
from
b87d28f
to
2fe7004
Compare
wakingrufus
force-pushed
the
drop-gradle-6
branch
from
2fe7004
to
5d0148c
Compare
JLLeitschuh
reviewed
Nov 12, 2023
|
Does the supported Gradle version match the version range supported by the Android plugin? |
We will be moving to requiring AGP 7.0 which requires Gradle 7.0, so this will be aligned. |
wakingrufus
force-pushed
the
drop-gradle-6
branch
from
5d0148c
to
861d2ae
Compare
increase minimum supported gradle version to 7.4.1 increase minimum supported ktlint version to 0.47.1 support ktlint 1.0.1 remove retry plugin as it is included in enterprise plugin now upgrade project gradle update code to utilize kotlin-dsl fix ktlint errors upgrade build to gradle 8 and add toolchain resolver update reporter samples to ktlint 1.0.1
wakingrufus
force-pushed
the
drop-gradle-6
branch
from
861d2ae
to
e352ba8
Compare
|
Nice work on this, quite a bit of effort was clearly required. I'm very impressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change default version of ktlint to 1.0.1
increase minimum supported gradle version to 7.4.1
increase minimum supported ktlint version to 0.47.1
support ktlint 1.0.1
remove retry plugin as it is included in enterprise plugin now
update code to utilize kotlin-dsl
fix ktlint errors
upgrade build to gradle 8 and add toolchain resolver
update reporter samples to ktlint 1.0.1