Skip to content
This repository was archived by the owner on Jun 26, 2022. It is now read-only.

댓글, 대댓글 기능 수정 #8

Merged
merged 3 commits into from
Apr 23, 2020
Merged

댓글, 대댓글 기능 수정 #8

merged 3 commits into from
Apr 23, 2020

Conversation

JHyeok
Copy link
Owner

@JHyeok JHyeok commented Apr 23, 2020

What is this PR? 🔍

댓글, 대댓글 기능 수정

Changes 📝

  • 댓글 삭제와 대댓글 삭제를 물리적 삭제에서 논리적 삭제로 변경
  • 게시글의 댓글 목록 반환 때, 총 댓글 갯수(댓글 + 답글) 반환하도록 수정
  • 사용자가 작성한 게시글, 댓글을 반환할 때 유저 정보를 포함하지 않도록 수정

Screenshot 📷

[x]

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #8 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   97.90%   97.92%   +0.01%     
==========================================
  Files          31       31              
  Lines         574      578       +4     
  Branches       43       43              
==========================================
+ Hits          562      566       +4     
  Misses         12       12              
Impacted Files Coverage Δ
src/repositories/PostCommentRepository.ts 100.00% <ø> (ø)
src/repositories/PostRepository.ts 100.00% <ø> (ø)
src/services/PostCommentService.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e521fc...8c5c78d. Read the comment docs.

@JHyeok JHyeok merged commit 2f0d869 into master Apr 23, 2020
@JHyeok JHyeok deleted the hotfix/comment-reply branch April 23, 2020 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant